fix(core)!: sort validate set by shard key #4952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
changed the title
stringhandler
approved these changes
Nov 24, 2022
stringhandler
pushed a commit
to tari-project/tari-dan
that referenced
this pull request
Nov 25, 2022
Description --- - Fixes QC Merkle root mismatch - add borsh encoding consensus hasher and tari_bor crate, so that it does not have to depend on tari_template_abi - removed a number of panics - domain separated hashing - number of small fixes - updated integration tests Motivation and Context --- Relies on tari-project/tari#4952 Fixes #218 How Has This Been Tested? --- Manually Existing tests updated
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Nov 28, 2022
* feature-dan: fix(core)!: sort validate set by shard key (tari-project#4952) update validator signature feat!: implement validator node registration as per RFC-0313 (tari-project#4928)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sorts VN set by shard id before returning it
Motivation and Context
Ref tari-project/rfcs#73
How Has This Been Tested?
Tests updated