Add GitHub Actions workflow 'test' #249
Conversation
|
Hey. FYI, Yesterday I created a PR to test releases before we push them to PyPI. When that is merged, I'll be more confident about resuming merges and releases. I'll try to look at this PR soon. Thank you for creating it! |
|
I think this PR can be deleted if we merge #230 |
tartley
added
the
process
| pull_request: | ||
| schedule: | ||
| - cron: '0 0 * * 5' | ||
| workflow_dispatch: |
There was a problem hiding this comment.
I'm not a fan of running test jobs on a schedule. They should be in response to commits or pushes.
| FORCE_COLOR: true | ||
| - run: ./demos/demo.sh | ||
| env: | ||
| NO_COLOR: true |
There was a problem hiding this comment.
I don't think we should be automating the use of 'demo.sh' as a form of test. I'd prefer we leaned more into creating genuine automated tests, not things that need human eyeballs.
|
|
||
| - on Windows or if output is redirected (not a tty) | ||
| - or if the ``NO_COLOR`` environment variable is set (with any value) | ||
| - and ``FORCE_COLOR`` not set (with any value) |
There was a problem hiding this comment.
I don't think these changes should be in this PR, am I misunderstanding?
|
|
||
| - on Windows and output is to a tty (terminal) | ||
| - or if the ``FORCE_COLOR`` environment variable is set (with any value) | ||
| - and ``NO_COLOR`` is not set (with any value) |
There was a problem hiding this comment.
don't think these should be here
| color_allowed = True | ||
| else: | ||
| color_allowed = not_closed and self.stream.isatty() | ||
|
|
There was a problem hiding this comment.
I don't think these changes should be in this PR
| @@ -8,6 +8,8 @@ | |||
| :: Implemented as a bash script which invokes python so that we can test the | |||
| :: behaviour on exit, which resets default colors again. | |||
|
|
|||
| cd /d "%~dp0" | |||
|
|
|||
There was a problem hiding this comment.
Help me understand the motivation for these. They are probably sensible, I just like MPs to be self-explanatory, rather than readers speculating what changes are for.
This PR is based on #230
Context: #230 (comment)