Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to test releases #276

Merged
merged 3 commits into from
Oct 15, 2020
Merged

Script to test releases #276

merged 3 commits into from
Oct 15, 2020

Conversation

tartley
Copy link
Owner

@tartley tartley commented Oct 12, 2020

Add a new 'test-release' script and makefile target

Running the script sends the already built package to
test pypi, then uses pip to download and install it from
there, and does a minimal invocation of the installed
package. If the package has not been built correctly,
this might detect some errors before we send it to
the real pypi.

Running the script sends the already built package to
test pypi, then uses pip to download and install it from
there, and does a minimal invocation of the installed
package. If the package has not been built correctly,
this might detect some errors before we send it to
the real pypi.
@@ -48,11 +49,16 @@ test: ## Run tests

# build packages

build: clean ## Build an sdist and wheel
build: ## Build an sdist and wheel
$(python) -m pip install --upgrade setuptools wheel
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent of this PR's main point, doing 'clean' before attempting to build doesn't work. There is no $(python) to call, because the virtualenv has been cleaned.

In addition, we now update to latest setuptools and wheel before attempting to build wheels.

upload: ## Upload our sdist and wheel
$(twine) upload dist/*
$(twine) upload dist/colorama-$(version)-*
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent of this PR's main point, we now just try to upload the current version, not everything in the dist dir.

@tartley
Copy link
Owner Author

tartley commented Oct 12, 2020

@wiggin15 FYI, this script to test new releases using the "test PyPI" passes when I run it from Linux. I'll try it on Windows too, then consider making a new release...

@tartley
Copy link
Owner Author

tartley commented Oct 12, 2020

I thought I'd be able to tweak a couple of things in the script to make it runnable from Windows, but am failing. I may replace the script with a .bat powershell file...

I initially hoped to have a single Makefile or script that
worked on Linux and Windows, but was unable to make it work
without massive over-complication.

So now we have makefile targets for Linux, and powershell
scripts for Windows. Documented in the README.
@tartley tartley linked an issue Oct 13, 2020 that may be closed by this pull request
@tartley tartley merged commit edcc4dd into master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify that built wheels work before releasing to PyPI
1 participant