Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

token mandatory? #490

Closed
japrescott opened this issue Apr 22, 2021 · 4 comments
Closed

token mandatory? #490

japrescott opened this issue Apr 22, 2021 · 4 comments
Labels

Comments

@japrescott
Copy link

1.6.0 broke our system as we now need to pass a mandatory token. I saw the discussion in #484 where the token was originally optional but @roggervalf suggested it shall be mandatory.
There is no reference to an issue or any detail for what this token could/shall be used for. It seems totally useless. Anyone care to elaborate what the idea behind it is?

@manast
Copy link
Contributor

manast commented Apr 22, 2021

ahh, ok. This is my fault. I was not thinking correctly here. I will make it optional and make a new release, sorry for the mistake.

@manast manast closed this as completed in 3940bd7 Apr 22, 2021
github-actions bot pushed a commit that referenced this issue Apr 22, 2021
## [1.20.1](v1.20.0...v1.20.1) (2021-04-22)

### Bug Fixes

* **worker:** make token optional in processor function fixes [#490](#490) ([3940bd7](3940bd7))
@github-actions
Copy link

🎉 This issue has been resolved in version 1.20.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@japrescott
Copy link
Author

@manast wow, didnt expect this to be fixed. I was more wondering what the use-case for this token is? So one can pass "secret" information to a job?

@manast
Copy link
Contributor

manast commented Apr 22, 2021

We are working on a use case where you can move the job to a different state from within the processor, and for that you need the token of that worker. But this is optional and will be explained in the documentation when it is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants