Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing token in processor function #484

Merged
merged 4 commits into from
Apr 21, 2021

Conversation

roggervalf
Copy link
Collaborator

No description provided.

@@ -6,6 +6,7 @@ import { AdvancedOptions, QueueBaseOptions, RateLimiterOptions } from './';
*/
export type Processor<T = any, R = any, N extends string = string> = (
job: Job<T, R, N>,
token?: string,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it cannot be optional, it is always there but you optionally use it or not :).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me address it really quick :sonic:

Copy link
Contributor

@manast manast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a small comment

@manast manast merged commit 2249724 into taskforcesh:master Apr 21, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@roggervalf roggervalf deleted the feat-pass-token-in-processor branch April 21, 2021 13:54
@japrescott japrescott mentioned this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants