-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extends null #543
Comments
@bterlson special case for usage var this = Parent !== null ? Reflect.construct(Parent, args, new.target) : Object.create(new.target.prototype); |
I agree. I think it is a specification bug that |
@bterlson Assuming I'm following this right, this still means the existing spec behavior of
will throw because I'll admit, auto-initializing |
Yep, good catch, overlooked it (and fixed via a35f0f3). I don't think super makes sense here since there is no super constructor. |
The latest revision of ECMA262 makes special provisions for classes which extend the `null` value [1]. Update the relevant tests accordingly. [1] tc39/ecma262#543
The latest revision of ECMA262 makes special provisions for classes which extend the `null` value [1]. Update the relevant tests accordingly. [1] tc39/ecma262#543
The latest revision of ECMA262 makes special provisions for classes which extend the `null` value [1]. Update the relevant tests accordingly. [1] tc39/ecma262#543
The latest revision of ECMA262 makes special provisions for classes which extend the `null` value [1]. Update the relevant tests accordingly. [1] tc39/ecma262#543
The change here makes sense to me, but I missed this thread until the test262 test went in and V8 failed it. I'm wondering, for normative changes like this, would it make sense to summarize them at TC39 (or some other place which really highlights it), and get some implementation feedback (or documentation that an implementation already does this) before committing? |
It does not allow me to sleep for a year. It was broken after the last class reform. See the last sentence. For usage
this
should be calledsuper
, but we can't callnull
. This issue was closed. Now added many serious changes for ES6, so maybe makes sense fixextends null
like it was proposed in #22? Usagethis
in extended fromnull
constructors withoutsuper
or a special case forsuper
in those constructors should not break any current code, but should makeextends null
useful instead of current useless garbage in the spec.The text was updated successfully, but these errors were encountered: