Update tests concerning null-extending classes #658
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest revision of ECMA262 makes special provisions for classes
which extend the
null
value [1]. Update the relevant testsaccordingly.
[1] tc39/ecma262#543
@bterlson I believe this fully addresses gh-588. As far as I can tell, there
are two observable difference for that change in the spec:
required a return value in this case, and I've updated the relevant test)
this
may be referenced from within the constructor (ES2016 does not allowsuch a reference, but we previously had no test for that)
SuperCall continues to be invalid for the same reason. Despite the fact that
there was no change to that behavior, I added a test for good measure.
I'm reasonably confident that there are no lingering tests for the outdated
semantics. (My heuristic is manually inspecting all files that contain the
strings "extends" and "null" but not necessarily on the same line.)
This should resolve gh-588.