Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: add RegExp Match Indices #1713

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Normative: add RegExp Match Indices #1713

merged 1 commit into from
Mar 16, 2022

Conversation

rbuckton
Copy link
Contributor

@rbuckton rbuckton commented Oct 1, 2019 •
edited by ljharb
Loading

This adds the specification text from https://github.com/tc39/proposal-regexp-match-indices, currently at Stage 3.

@rbuckton rbuckton mentioned this pull request Oct 1, 2019
Closed
9 tasks
@ljharb ljharb changed the title Add spec text for regexp-match-indices Normative: add RegExp Match Indices Oct 1, 2019
@ljharb ljharb added needs test262 tests The proposal should specify how to test an implementation. Ideally via github.com/tc39/test262 normative change Affects behavior required to correctly evaluate some ECMAScript source text pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. labels Oct 1, 2019
ljharb
ljharb reviewed Oct 1, 2019
View reviewed changes
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
@rbuckton rbuckton force-pushed the regexp-match-indices branch from d2b0589 to ba92766 Compare October 2, 2019 00:25
@rbuckton
Copy link
Contributor Author

rbuckton commented Oct 2, 2019

Test262 Tests have already been merged: tc39/test262#2309

@ljharb ljharb added has test262 tests and removed needs test262 tests The proposal should specify how to test an implementation. Ideally via github.com/tc39/test262 labels Oct 2, 2019
@jmdyck
Copy link
Collaborator

jmdyck commented Oct 3, 2019

I've submitted an editorial PR against this PR's branch.

@ljharb ljharb marked this pull request as draft July 15, 2020 21:56
rbuckton added a commit to rbuckton/ecma262 that referenced this pull request Jan 15, 2021
@rbuckton
Merge pull request #1 from jmdyck/1713_ed
8d897d4 
Editorial tweaks re PR tc39#1713
@rbuckton
Copy link
Contributor Author

rbuckton commented Jan 15, 2021 •
edited
Loading

NOTE: I still need to update the specification text based on the changes in tc39/proposal-regexp-match-indices#49

This has now been completed.

@rbuckton rbuckton marked this pull request as ready for review February 23, 2021 02:11
@rbuckton rbuckton force-pushed the regexp-match-indices branch from 48f9a15 to 683300e Compare February 23, 2021 02:31
jmdyck
jmdyck requested changes Feb 24, 2021
View reviewed changes
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
@rbuckton
Copy link
Contributor Author

@ljharb, I know you approved this prior to the addition of the d flag. Can you take another look to make sure I haven't missed any thing editorially in the process of updating this PR?

jmdyck
jmdyck reviewed Feb 26, 2021
View reviewed changes
spec.html Outdated Show resolved Hide resolved
ljharb
ljharb approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM

spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
jmdyck
jmdyck reviewed Feb 26, 2021
View reviewed changes
spec.html Outdated Show resolved Hide resolved
@rbuckton rbuckton force-pushed the regexp-match-indices branch from 9958ad7 to 3d1c29c Compare February 26, 2021 22:35
@jmdyck jmdyck mentioned this pull request Mar 3, 2021
Merged
@bakkot bakkot removed the editor call to be discussed in the next editor call label Feb 9, 2022
michaelficarra
michaelficarra reviewed Mar 10, 2022
View reviewed changes
spec.html Outdated Show resolved Hide resolved
michaelficarra
michaelficarra reviewed Mar 10, 2022
View reviewed changes
spec.html Outdated Show resolved Hide resolved
michaelficarra
michaelficarra reviewed Mar 10, 2022
View reviewed changes
spec.html Outdated Show resolved Hide resolved
michaelficarra
michaelficarra reviewed Mar 10, 2022
View reviewed changes
spec.html Outdated Show resolved Hide resolved
michaelficarra
michaelficarra reviewed Mar 10, 2022
View reviewed changes
spec.html Outdated Show resolved Hide resolved
michaelficarra
michaelficarra reviewed Mar 10, 2022
View reviewed changes
spec.html Outdated Show resolved Hide resolved
michaelficarra
michaelficarra reviewed Mar 10, 2022
View reviewed changes
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

michaelficarra
michaelficarra reviewed Mar 11, 2022
View reviewed changes
spec.html Outdated Show resolved Hide resolved
@michaelficarra
Copy link
Member

@rbuckton I've rebased your PR and applied my editorial changes.

michaelficarra
michaelficarra reviewed Mar 11, 2022
View reviewed changes
spec.html
1. Assert: _match_.[[StartIndex]] is an integer value ≥ 0 and < the length of _S_.
1. Assert: _match_.[[EndIndex]] is an integer value ≥ _match_.[[StartIndex]] and ≤ the length of _S_.
1. Return ! CreateArrayFromList(« 𝔽(_match_.[[StartIndex]]), 𝔽(_match_.[[EndIndex]]) »).
1. Assert: _match_.[[StartIndex]] is a non-negative integer less than or equal to the length of _S_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was totally on purpose and not an accident.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not against its being in prose, but what was the reasoning here and above?

syg
syg approved these changes Mar 15, 2022
View reviewed changes
spec.html
1. Assert: _match_.[[StartIndex]] is an integer value ≥ 0 and < the length of _S_.
1. Assert: _match_.[[EndIndex]] is an integer value ≥ _match_.[[StartIndex]] and ≤ the length of _S_.
1. Return ! CreateArrayFromList(« 𝔽(_match_.[[StartIndex]]), 𝔽(_match_.[[EndIndex]]) »).
1. Assert: _match_.[[StartIndex]] is a non-negative integer less than or equal to the length of _S_.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not against its being in prose, but what was the reasoning here and above?

spec.html Show resolved Hide resolved
@michaelficarra michaelficarra added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Mar 16, 2022
@ljharb ljharb dismissed jmdyck’s stale review March 16, 2022 21:50

changes addressed

@ljharb ljharb force-pushed the regexp-match-indices branch from efc369b to 0209d85 Compare March 16, 2022 21:52
@ljharb ljharb merged commit 0209d85 into tc39:main Mar 16, 2022
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Mar 17, 2022
@jmdyck
Editorial: Fix the return-type of CompilePattern
1e98a9f 
PR tc39#1713 changed the signature of the Abstract Closure
created+returned by CompilePattern,
but didn't make the corresponding change
to the return-type in the section heading.
@jmdyck jmdyck mentioned this pull request Mar 17, 2022
Merged
ljharb pushed a commit to jmdyck/ecma262 that referenced this pull request Mar 27, 2022
@jmdyck @ljharb
Editorial: Fix the return-type of CompilePattern (tc39#2698)
700b994 
PR tc39#1713 changed the signature of the Abstract Closure
created+returned by CompilePattern,
but didn't make the corresponding change
to the return-type in the section heading.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdyck jmdyck jmdyck left review comments

@michaelficarra michaelficarra michaelficarra approved these changes

@syg syg syg approved these changes

@ljharb ljharb ljharb approved these changes

@bakkot bakkot bakkot approved these changes

@mathiasbynens mathiasbynens Awaiting requested review from mathiasbynens

@waldemarhorwat waldemarhorwat Awaiting requested review from waldemarhorwat

@msaboff msaboff Awaiting requested review from msaboff

Assignees
No one assigned
Labels
has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. has test262 tests normative change Affects behavior required to correctly evaluate some ECMAScript source text proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rbuckton @jmdyck @ljharb @michaelficarra @syg @bakkot