Add tests for regexp-match-indices #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
@leobalter I take it there's currently no way to specify that a specific host argument is required for a test? The feature is currently enabled in V8 v7.8 under the |
Test262 is agostic with the host usage and there isn't any mapping to arguments used by any. A test runner consuming test262 could easily do this mapping from the features flags but there isn't anything already doing it. |
leobalter
suggested changes
Aug 28, 2019
test/built-ins/RegExp/match-indices/indices-array-unicode-match.js
Outdated
Show resolved
Hide resolved
rbuckton
force-pushed
the
regexp-match-indices
branch
from
0b040c7 to
85db19d
Compare
leobalter
previously approved these changes
Sep 18, 2019
leobalter
approved these changes
Sep 18, 2019
jugglinmike
added a commit
to bocoup/test262
that referenced
this pull request
Sep 18, 2021
The `assert.deepEqual` utility method was originally implemented in support of two tests for the "RegExp Match Indices" proposal [1]. In the years since that time, it has been referenced by one additional test, where it is interchangeable with the considerably simpler `assert.compareArray`. Refactor the RegExp tests to use a simpler inline helper function that verifies the same semantics and preserves meaningful error messages. [1] tc39#2309
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for https://github.com/tc39/proposal-regexp-match-indices