-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorial: Fix %Generator% and %AsyncGenerator% <dfn>s #2059
Editorial: Fix %Generator% and %AsyncGenerator% <dfn>s #2059
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not consistent with whether we're saying "is the intrinsic object %Foo%" or "is %Foo%". My preference is we standardize on the latter.
Before I stamp this, I'd like to see what @ljharb @bakkot @michaelficarra think.
Well, all non‑dotted intrinsic There’s also “This function is the <dfn>%FooProto_baz%</dfn> intrinsic object.”, but that’s used only in prose after |
Ah I see, thanks for pointing this out. I retract my inconsistency statement. Still, I'm not sure the "intrinsic object %Foo%" is any clearer than "%Foo%". While it is true all %Foo% without dotted access are objects, is that property that salient? |
PR #1376 deleted "the intrinsic object" from pretty much every occurrence of "the intrinsic object %Foo%", other than the ones with |
At this point, regardless what I may have thought previously, I think "is |
ddf0a36
to
58bf556
Compare
The editors have decided to remove the redundant "the intrinsic object" phrasing, which I've included in this PR as a separate editorial commit, and rebased the PR's original commit on top of it. |
Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
58bf556
to
4b7aa90
Compare
Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
4b7aa90
to
7426ddf
Compare
Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>
7426ddf
to
e8fd7ba
Compare
Currently,
%AsyncGenerator%
auto‑links to https://tc39.es/ecma262/#sec-asyncgeneratorfunction-prototype instead of https://tc39.es/ecma262/#sec-properties-of-asyncgeneratorfunction-prototype.I also sorted the
<ul>
to match other definitions and made the “see Figure” text an<emu‑xref>
.Preview (#sec-well-known-intrinsic-objects, #sec-properties-of-asyncgeneratorfunction-prototype)