Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Fix %Generator% and %AsyncGenerator% <dfn>s #2059

Merged
merged 2 commits into from
Jul 16, 2020

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Jun 20, 2020

Currently, %AsyncGenerator% auto‑links to https://tc39.es/ecma262/#sec-asyncgeneratorfunction-prototype instead of https://tc39.es/ecma262/#sec-properties-of-asyncgeneratorfunction-prototype.

I also sorted the <ul> to match other definitions and made the “see Figure” text an <emu‑xref>.


Preview (#sec-well-known-intrinsic-objects, #sec-properties-of-asyncgeneratorfunction-prototype)

@ljharb ljharb requested review from michaelficarra, syg, bakkot and a team June 20, 2020 06:32
spec.html Outdated Show resolved Hide resolved
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not consistent with whether we're saying "is the intrinsic object %Foo%" or "is %Foo%". My preference is we standardize on the latter.

Before I stamp this, I'd like to see what @ljharb @bakkot @michaelficarra think.

@ExE-Boss
Copy link
Contributor Author

ExE-Boss commented Jun 30, 2020

Well, all non‑dotted intrinsic <dfn>s all use “is the intrinsic object <dfn>%Foo%</dfn>”, and all (1) dotted intrinsic <dfn>s currently use “is <dfn>%Foo.bar%</dfn>”.

There’s also “This function is the <dfn>%FooProto_baz%</dfn> intrinsic object.”, but that’s used only in prose after <emu‑alg>.

@syg
Copy link
Contributor

syg commented Jun 30, 2020

Well, all non‑dotted intrinsic s all use “is the intrinsic object %Foo%”, and all (1) dotted intrinsic s currently use “is %Foo.bar%”.

Ah I see, thanks for pointing this out. I retract my inconsistency statement. Still, I'm not sure the "intrinsic object %Foo%" is any clearer than "%Foo%". While it is true all %Foo% without dotted access are objects, is that property that salient?

@jmdyck
Copy link
Collaborator

jmdyck commented Jun 30, 2020

We're not consistent with whether we're saying "is the intrinsic object %Foo%" or "is %Foo%". My preference is we standardize on the latter.

PR #1376 deleted "the intrinsic object" from pretty much every occurrence of "the intrinsic object %Foo%", other than the ones with <dfn>...</dfn> around "%Foo%". I think @ljharb gave a reason for excluding the latter cases, but I can't find it.

@ljharb
Copy link
Member

ljharb commented Jun 30, 2020

At this point, regardless what I may have thought previously, I think "is %Foo%" or "is %Foo.bar%" is clearer. The very use of the % syntax implies "intrinsic", and as such, is redundant.

@ljharb ljharb added the editor call to be discussed in the next editor call label Jul 1, 2020
@ljharb ljharb force-pushed the editorial/fix-asyncgenerator-definition branch from ddf0a36 to 58bf556 Compare July 1, 2020 23:07
@ljharb
Copy link
Member

ljharb commented Jul 1, 2020

The editors have decided to remove the redundant "the intrinsic object" phrasing, which I've included in this PR as a separate editorial commit, and rebased the PR's original commit on top of it.

@ljharb ljharb removed the editor call to be discussed in the next editor call label Jul 1, 2020
@ljharb ljharb requested review from bakkot, syg and a team July 1, 2020 23:08
ExE-Boss added a commit to ExE-Boss/ecma262 that referenced this pull request Jul 2, 2020
Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@ExE-Boss ExE-Boss force-pushed the editorial/fix-asyncgenerator-definition branch from 58bf556 to 4b7aa90 Compare July 2, 2020 15:23
ExE-Boss added a commit to ExE-Boss/ecma262 that referenced this pull request Jul 2, 2020
Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@ExE-Boss ExE-Boss force-pushed the editorial/fix-asyncgenerator-definition branch from 4b7aa90 to 7426ddf Compare July 2, 2020 15:36
Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@ljharb ljharb force-pushed the editorial/fix-asyncgenerator-definition branch from 7426ddf to e8fd7ba Compare July 16, 2020 05:54
@ljharb ljharb merged commit e8fd7ba into tc39:master Jul 16, 2020
@ljharb ljharb deleted the editorial/fix-asyncgenerator-definition branch July 16, 2020 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants