Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Disallow '_' for calendar , referring to UTS35 #647

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Normative: Disallow '_' for calendar , referring to UTS35 #647

merged 1 commit into from
Mar 28, 2022

Conversation

FrankYFTang
Copy link
Contributor

Make it clear "_" is not acceptable for calendar code

@FrankYFTang
Copy link
Contributor Author

This is response for our discussion in TG2 2022-01-03 and agree the "_" should cause a throw of error and we should make it clear in the spec.

@FrankYFTang
Copy link
Contributor Author

address tc39/test262#3173

@FrankYFTang FrankYFTang mentioned this pull request Jan 13, 2022
Merged
@FrankYFTang FrankYFTang mentioned this pull request Jan 14, 2022
Closed
@FrankYFTang
Copy link
Contributor Author

fix #646

ryzokuken
ryzokuken approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presenting this to plenary today.

@ryzokuken
Copy link
Member

2022-01-24: Approved by TC39-TG1.

@ryzokuken
Copy link
Member

@FrankYFTang has this been approved by TG2 in the past? If so, I could merge this right away.

@sffc
Copy link
Contributor

sffc commented Mar 17, 2022

TG2 consensus: https://github.com/tc39/ecma402/blob/master/meetings/notes-2022-03-17.md#normative-disallow-_-for-calendar--referring-to-uts35

Also good for including in ES 2022.

@FrankYFTang @leobalter
Disallow '_' for calendar , referring to UTS35
0785d91 
Make it clear "_" is not acceptable for calendar code
@leobalter leobalter merged commit 2703d06 into master Mar 28, 2022
@leobalter leobalter deleted the FrankYFTang-patch-2 branch March 28, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzokuken ryzokuken ryzokuken approved these changes

@gibson042 gibson042 gibson042 approved these changes

@leobalter leobalter leobalter approved these changes

Assignees
No one assigned
Labels
normative
Projects
ECMA-402 Meeting Topics
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@FrankYFTang @ryzokuken @sffc @leobalter @gibson042 @romulocintra