Spec: Throw on undefined calendar in Temporal.now #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1391 +/- ##
=======================================
Coverage 95.36% 95.37%
=======================================
Files 19 19
Lines 11137 11154 +17
Branches 1829 1832 +3
=======================================
+ Hits 10621 10638 +17
Misses 511 511
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
cjtenny
force-pushed
the
optional-calendars-now
branch
from
a79c751
to
2df1a50
Compare
|
Should adjust #1392 to match if allowing undefined calendars is what we want; otherwise I'll redo this change to fix the spec to match the polyfill + docs. |
ptomato
previously requested changes
Feb 26, 2021
cjtenny
force-pushed
the
optional-calendars-now
branch
from
2df1a50
to
9671145
Compare
cjtenny
changed the title
|
Got it. Changed to reflect that! |
cjtenny
force-pushed
the
optional-calendars-now
branch
from
9671145
to
b3b4971
Compare
cjtenny
force-pushed
the
optional-calendars-now
branch
from
b3b4971
to
c44fa15
Compare
Ms2ger
approved these changes
Feb 26, 2021
cjtenny
added a commit
that referenced
this pull request
Feb 27, 2021
Running all the code samples in the docs through a tolerant markdown snippet parser + execution environment revealed many errors. #1395, #1391, #1380, and this patch's one-line fix in plainmonthday.mjs were all bugs revealed by the documentation code samples. Many of the changes in this patch are slight syntactic changes to make the samples testable and more clear.
cjtenny
added a commit
that referenced
this pull request
Feb 27, 2021
Running all the code samples in the docs through a tolerant markdown snippet parser + execution environment revealed many errors. #1395, #1391, #1380, and this patch's one-line fix in plainmonthday.mjs were all bugs revealed by the documentation code samples. Many of the changes in this patch are slight syntactic changes to make the samples testable and more clear. Common classes of smaller issues fixed: - Examples did not include seconds in string representations - Examples contained extra zeroes of precision when not requested - Old calling conventions used; arguments needed to be changed - Some options bags are now used in dedicated places rather than alongside other methods
cjtenny
added a commit
that referenced
this pull request
Apr 8, 2021
Running all the code samples in the docs through a tolerant markdown snippet parser + execution environment revealed many errors. #1395, #1391, #1380, and this patch's one-line fix in plainmonthday.mjs were all bugs revealed by the documentation code samples. Many of the changes in this patch are slight syntactic changes to make the samples testable and more clear. Common classes of smaller issues fixed: - Examples did not include seconds in string representations - Examples contained extra zeroes of precision when not requested - Old calling conventions used; arguments needed to be changed - Some options bags are now used in dedicated places rather than alongside other methods
cjtenny
added a commit
that referenced
this pull request
Apr 13, 2021
Running all the code samples in the docs through a tolerant markdown snippet parser + execution environment revealed many errors. #1395, #1391, #1380, and this patch's one-line fix in plainmonthday.mjs were all bugs revealed by the documentation code samples. Many of the changes in this patch are slight syntactic changes to make the samples testable and more clear. Common classes of smaller issues fixed: - Examples did not include seconds in string representations - Examples contained extra zeroes of precision when not requested - Old calling conventions used; arguments needed to be changed - Some options bags are now used in dedicated places rather than alongside other methods
cjtenny
added a commit
that referenced
this pull request
Apr 13, 2021
Running all the code samples in the docs through a tolerant markdown snippet parser + execution environment revealed many errors. #1395, #1391, #1380, and this patch's one-line fix in plainmonthday.mjs were all bugs revealed by the documentation code samples. Many of the changes in this patch are slight syntactic changes to make the samples testable and more clear. Common classes of smaller issues fixed: - Examples did not include seconds in string representations - Examples contained extra zeroes of precision when not requested - Old calling conventions used; arguments needed to be changed - Some options bags are now used in dedicated places rather than alongside other methods
cjtenny
added a commit
that referenced
this pull request
Apr 13, 2021
Running all the code samples in the docs through a tolerant markdown snippet parser + execution environment revealed many errors. #1395, #1391, #1380, and this patch's one-line fix in plainmonthday.mjs were all bugs revealed by the documentation code samples. Many of the changes in this patch are slight syntactic changes to make the samples testable and more clear. Common classes of smaller issues fixed: - Examples did not include seconds in string representations - Examples contained extra zeroes of precision when not requested - Old calling conventions used; arguments needed to be changed - Some options bags are now used in dedicated places rather than alongside other methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found another spec discrepancy while auditing docs code samples, where the docs+polyfill disagree with spec.
Temporal.now.{plainDate,plainDateTime,zonedDateTime}()should accept undefined calendar because they all delegate to SystemDateTime which usesToOptionalTemporalCalendar. However, calendarLike isn't listed as an optional argument.Which is the correct behavior? Assuming the spec is correct, this makes the polyfill match and adds some optionality-brackets to the spec for clarity.