Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up TypeScript descriptions for .now methods #1392

Merged
merged 2 commits into from
Feb 26, 2021

Conversation

gilmoreorless
Copy link
Contributor

I noticed some of the TypeScript definitions for the Temporal.now methods had slightly incorrect descriptions (mostly looked like copy/paste errors).

This tidies up the descriptions to be consistent, and also fixes a couple of other typos I found elsewhere in the file.

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #1392 (796fbdc) into main (824923a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1392   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files          19       19           
  Lines       11137    11137           
  Branches     1829     1829           
=======================================
  Hits        10621    10621           
  Misses        511      511           
  Partials        5        5           
Flag Coverage Δ
test262 48.39% <ø> (ø)
tests 91.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 824923a...2aade09. Read the comment docs.

Copy link
Collaborator

@ptomato ptomato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanups, all looks correct!

@ptomato ptomato merged commit 658a12c into tc39:main Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants