Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Array,%TypedArray%}.prototype.sort should throw on a non-undefined non-function #1059

Merged
merged 1 commit into from
Jun 12, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
// Copyright (C) 2017 Jordan Harband. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-array.prototype.sort
description: throws on a non-undefined non-function
info: >
22.1.3.25 Array.prototype.sort ( comparefn )

Upon entry, the following steps are performed to initialize evaluation
of the sort function:

...
1. If _comparefn_ is not *undefined* and IsCallable(_comparefn_) is *false*, throw a *TypeError* exception.
...
---*/

var sample = [1, 2, 3];

assert.throws(TypeError, function() {
sample.sort(null);
});

assert.throws(TypeError, function() {
sample.sort(true);
});

assert.throws(TypeError, function() {
sample.sort(false);
});

assert.throws(TypeError, function() {
sample.sort('');
});

assert.throws(TypeError, function() {
sample.sort(/a/g);
});

assert.throws(TypeError, function() {
sample.sort(42);
});

assert.throws(TypeError, function() {
sample.sort([]);
});

assert.throws(TypeError, function() {
sample.sort({});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
// Copyright (C) 2017 Jordan Harband. All rights reserved.
// This code is governed by the BSD license found in the LICENSE file.
/*---
esid: sec-%typedarray%.prototype.sort
description: throws on a non-undefined non-function
info: >
22.2.3.26 %TypedArray%.prototype.sort ( comparefn )

Upon entry, the following steps are performed to initialize evaluation
of the sort function. These steps are used instead of the entry steps
in 22.1.3.25:

...
1. If _comparefn_ is not *undefined* and IsCallable(_comparefn_) is *false*, throw a *TypeError* exception.
...

includes: [testTypedArray.js]
---*/

testWithTypedArrayConstructors(function(TA) {
var sample = new TA([42, 43, 44, 45, 46]);

assert.throws(TypeError, function() {
sample.sort(null);
});

assert.throws(TypeError, function() {
sample.sort(true);
});

assert.throws(TypeError, function() {
sample.sort(false);
});

assert.throws(TypeError, function() {
sample.sort('');
});

assert.throws(TypeError, function() {
sample.sort(/a/g);
});

assert.throws(TypeError, function() {
sample.sort(42);
});

assert.throws(TypeError, function() {
sample.sort([]);
});

assert.throws(TypeError, function() {
sample.sort({});
});
});