Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename setupBy to deployedBy? #281

Closed
peterdesmet opened this issue Feb 7, 2023 · 1 comment
Closed

Rename setupBy to deployedBy? #281

peterdesmet opened this issue Feb 7, 2023 · 1 comment
Assignees
@peterdesmet
Labels
community:feedback level:deployments term:update
Milestone
1.0

Comments

@peterdesmet
Copy link
Member

Is deployment.setupBy not better named deployment.deployedBy?

camtrap-dp/deployments-table-schema.json

Lines 94 to 102 in d9009d4

{
"name": "setupBy",
"description": "Name or unique identifier of the person that deployed the camera.",
"type": "string",
"constraints": {
"required": false
},
"example": "Jakub Bubnicki"
},

See also #215 (comment)
@peterdesmet peterdesmet added this to the 1.0 milestone Feb 7, 2023
@peterdesmet peterdesmet self-assigned this Feb 7, 2023
peterdesmet added a commit that referenced this issue Feb 10, 2023
@peterdesmet
Change cameraSetup to enum
9440f90 
Fix #216
Fix #215
Fix #281
@peterdesmet
Copy link
Member Author

Decided to keep term name as is, see #215 (comment).

@peterdesmet peterdesmet mentioned this issue Feb 10, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterdesmet peterdesmet

Labels
community:feedback level:deployments term:update
Projects
No open projects
Camtrap DP v1.0-rc.1
Status: Done
Milestone
1.0
Development

No branches or pull requests
1 participant
@peterdesmet