Updates before splitting the observation table #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assifications See #170
- Remove `observations.deploymentID` from schema and example - Remove `observations.timestamp` from schema and example - Remove `observations.mediaID` from schema and example - Rename `media.sequenceID` to `media.eventID` in schema and example - Rename `observations.sequenceID` to `observations.eventID` in schema and example
Fix #200. It remains a broadMatch, since the Camtrap DP concept is narrower.
- Allowed roles: contact, principal investigator, rightsholder, publisher, contributor - Update roles in example - Include one contributor without role - Repeat INBO as rightsholder Fix #267
Rename classificationConfidence to classificationProbability, and note that it's usually omitted for human classifications
The validate_example_current_schema.py test verbosely included the table schemas, which will fail validation that is trying to prevent that.
1. Define all variables in helpers.py (only)
2. validate_profile_and_schemas.py:
- make use of new variables
3. validate_example_versioned_schema.py:
- document script
- make use of new variables
4. validate_example_current_schema.py
- document script
- make use of new variables
- match resource with table schema using table_schema.name.split("-")[0]) e.g. media-table-schema.json -> media
- link to table schema rather than verbosely including it
Validation never reached that point, because schema is interpreted as a string and properties (incl. "name") are therefore moot
Adding custom tables is possible as long as these don't use the Camtrap DP reserved table names - Also require Camtrap DP tables to be files (path, not data)
Co-Authored-By: EmmaCartuyvels1 <44839819+EmmaCartuyvels1@users.noreply.github.com> Co-Authored-By: nicolasvanermen <7381853+nicolasvanermen@users.noreply.github.com>
kbubnicki
approved these changes
Feb 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses all issues that can be tackled before splitting the observation table in two. It fixes the issues below. This PR should only be accepted when all included PRs are merged (checkboxes below).
General
latitude,longitude#270First step in restructuring
Classification method
classificationConfidencetoclassificationProbability#217Camera setup
setupandpickupas observationType #215calibrationas observationType #216setupBytodeployedBy? #281Other term updates
tagsterm to observations #287Website