Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch testcloud plugin to the Workarounds API #3036

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

frantisekz
Copy link
Collaborator

@frantisekz frantisekz commented Jun 20, 2024

This will allow to:

Requires https://pagure.io/testcloud/pull-request/173 ; built in https://copr.fedorainfracloud.org/coprs/frantisekz/testcloud-wip/build/7630902/

Known issues so far:

  • el9 host doesn't work - resolved
  • TBD

This is meant also as a RFC for the api itself, source and available methods can be seen at https://pagure.io/testcloud/blob/284f136fcbca4e9166d687e90f0108962c1bc8f1/f/testcloud/workarounds.py

@frantisekz frantisekz force-pushed the testcloud_workarounds branch 3 times, most recently from 7804b9f to 0878180 Compare June 20, 2024 20:43
@psss
Copy link
Collaborator

psss commented Jul 18, 2024

That would be nice, seems the problem still randomly appears. Here's a recent job for example. If possible, let's try to finish this in 1.36?

@psss psss added this to the 1.36 milestone Jul 18, 2024
@frantisekz
Copy link
Collaborator Author

That would be nice, seems the problem still randomly appears. Here's a recent job for example. If possible, let's try to finish this in 1.36?

I'd consider this one ready now, I've finished the integration part in testcloud - if it's okay with the one TODO item left, I'd go ahead and merge the changes testcloud side, release a new testcloud, and then this could get merged.

For testing - testcloud -800 is being built at https://copr.fedorainfracloud.org/coprs/frantisekz/testcloud-wip/builds/ .

@frantisekz
Copy link
Collaborator Author

@psss @martinhoyer @happz This one can now land into 1.35 if possible.

@happz happz added plugin | testcloud The testcloud virtual provision plugin ci | full test Pull request is ready for the full test execution labels Aug 6, 2024
@happz happz modified the milestones: 1.36, 1.35 Aug 6, 2024
@seberm seberm self-requested a review August 6, 2024 12:03
Copy link
Collaborator

@seberm seberm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the changes only locally with testcloud==0.9.13 and it seems everything is working fine.

Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Thanks for the improvement.

@happz happz added the status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish. label Aug 6, 2024
@happz happz merged commit 4ce0b9a into teemtee:main Aug 6, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci | full test Pull request is ready for the full test execution plugin | testcloud The testcloud virtual provision plugin status | ready for merge The only missing piece is to do the rebase the current 'main' and let the CI finish.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants