Proposed changes #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what I did yesterday: - basicly gave the tests more comprehensive names; put all the declarations at the top; got rid of the magic negative C-value (renamed to P + A, O, T) - "cos(RADIANS(180 + 30 * axis)) * (1 + circles * 0.1 * ((zig_zag) ? 1 : -1)) * delta_calibration_radius" compiles wrong is zig_zag statement is without brackets - DELTA_TOWER_ANGLE_TRIM reset to 3 values (the calcs use the 3th value to normalize will not compile otherwise) -Wrote 3 dummies to keep EEPROM lenght the same -Reset the configs to the 'original' with autocal + menu disabled (but can be enabled of course)
|
I'm just going to keep accepting these until you guys have it all sorted out. |
|
I have one more to come |
teemuatlut
pushed a commit
that referenced
this pull request
Oct 10, 2019
# This is the 1st commit message: Add Support for ADIMLab Granty # The commit message #2 will be skipped: # Update Configuration.h # The commit message #3 will be skipped: # Add files via upload # # Add Support for ADIMLab Granty # The commit message #4 will be skipped: # Create Configuration.h # The commit message #5 will be skipped: # Delete Configuration.h # The commit message #6 will be skipped: # Create Test.h # The commit message #7 will be skipped: # Add files via upload # The commit message #8 will be skipped: # Delete Test.h # The commit message #9 will be skipped: # Delete Configuration.h # The commit message #10 will be skipped: # Delete Configuration_adv.h # The commit message #11 will be skipped: # Add files via upload # # Add ADIMLab Pins # The commit message #12 will be skipped: # Add files via upload # # Add Bootscreen # The commit message #13 will be skipped: # Update Configuration.h # # Add Bootscreen # The commit message #14 will be skipped: # Update pins.h # # Add ADIMLab Board # The commit message #15 will be skipped: # Update boards.h # # Add ADIMLab Granty # The commit message #16 will be skipped: # Update Makefile # # Add ADIMLab Granty # The commit message #17 will be skipped: # Update boards.h # The commit message #18 will be skipped: # Update Makefile
teemuatlut
pushed a commit
that referenced
this pull request
Oct 10, 2019
* # This is a combination of 18 commits. # This is the 1st commit message: Add Support for ADIMLab Granty # The commit message #2 will be skipped: # Update Configuration.h # The commit message #3 will be skipped: # Add files via upload # # Add Support for ADIMLab Granty # The commit message #4 will be skipped: # Create Configuration.h # The commit message #5 will be skipped: # Delete Configuration.h # The commit message #6 will be skipped: # Create Test.h # The commit message #7 will be skipped: # Add files via upload # The commit message #8 will be skipped: # Delete Test.h # The commit message #9 will be skipped: # Delete Configuration.h # The commit message #10 will be skipped: # Delete Configuration_adv.h # The commit message #11 will be skipped: # Add files via upload # # Add ADIMLab Pins # The commit message #12 will be skipped: # Add files via upload # # Add Bootscreen # The commit message #13 will be skipped: # Update Configuration.h # # Add Bootscreen # The commit message #14 will be skipped: # Update pins.h # # Add ADIMLab Board # The commit message #15 will be skipped: # Update boards.h # # Add ADIMLab Granty # The commit message #16 will be skipped: # Update Makefile # # Add ADIMLab Granty # The commit message #17 will be skipped: # Update boards.h # The commit message #18 will be skipped: # Update Makefile * Add Support for ADIMLab Granty * Optimize bootscreen * Update Makefile Updated Description * Update boards.h Updated Description * Update pins_HJC2560C_REV2.h Updated Description * Update Configuration.h Added Author + Custom_Machine_Name * Create _Bootscreen.h Add Bootscreen * Add files via upload Add ADIMLab Granty v1 * Update boards.h Add ADIMLab Granty v1 * Update Makefile Add ADIMLab Granty v1 * Update pins_HJC2560C_REV2.h * Consolidate Granty configs * config updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I did yesterday:
basicly gave the tests more comprehensive names; put all the
declarations at the top; got rid of the 'magic' negative C-value (renamed
to P + A, O, T)
"cos(RADIANS(180 + 30 * axis)) * (1 + circles * 0.1 * ((zig_zag) ? 1 :
-1)) * delta_calibration_radius" compiles wrong is zig_zag statement is
without brackets
DELTA_TOWER_ANGLE_TRIM reset to 3 values (the calcs use the 3th value
to normalize will not compile otherwise)
-Wrote 3 dummies to keep EEPROM lenght the same
-Reset the configs to the 'original' with autocal + menu disabled (but
can be enabled of course)
note: it compiles with warnings in ultralcd.cpp about type conversions, but that's in stuff I didn't touch