Bugfix issue #7 on crc checksum failure #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements travis-ci integration, yet untested. I will have to clone the repository to allow travis-ci access for testing. Once I added tox support, I added python3 testing -- which immediately failed. I spent some time adding python3 support. Some of it may incur some small overhead. We can address these if we decide on a new API for YMODEM (multi-file, file-like iface) support. Additionally, debug logging is less verbose in the case of not logging each successful checksum -- and more verbose in the case of indicating each and every step through the transfer. These were decorated as I went with the python3 porting process.
…html URLS at the top for the TXT documents fail, because the docs/ are not provided with a source distribution
When a CRC checksum failure occurs and NAK is sent, 1. we should purge any awaiting stdin as suggested by ymodem.txt and documented therein, i would suppose this may only be for ymodem, which has a kind of readahead buffer, though. For xmodem local testing piped with lrzsz, no data is purged. 2. we should read the next start-of-header block, as is usually done when the checksum is valid -- this causes our 'seq1' to be SOH or STX, and seq2 fails 1's complement and subsequent failures about unexpected sequence occur, otherwise.
|
Changes Unknown when pulling de55d20 on fixing-crcfails into * on master*. |
|
Changes Unknown when pulling 75af6ba on fixing-crcfails into * on master*. |
|
Changes Unknown when pulling 471e4df on fixing-crcfails into * on master*. |
|
Changes Unknown when pulling 42b026c on fixing-crcfails into * on master*. |
tehmaze
added a commit
that referenced
this pull request
Dec 31, 2014
Bugfix issue #7 on crc checksum failure
|
Thanks again Jeff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Pull PR #8 and PR #10 first for smaller diff)
When a CRC checksum failure occurs and NAK is sent,
ymodem.txt and documented therein, i would suppose
this may only be for ymodem, which has a kind of
readahead buffer, though. For xmodem local testing
piped with lrzsz, no data is purged.
is usually done when the checksum is valid -- this
causes our 'seq1' to be SOH or STX, and seq2 fails
1's complement and subsequent failures about unexpected
sequence occur, otherwise.
As this is a bug, I have proposed bumping version to 0.4.0.