Use functional tests, python3 support (tox + py.test + lrzsz package) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements travis-ci integration, yet untested. I will have to clone the repository to allow travis-ci access for testing. Once I added tox support, I added python3 testing -- which immediately failed. I spent some time adding python3 support. Some of it may incur some small overhead. We can address these if we decide on a new API for YMODEM (multi-file, file-like iface) support. Additionally, debug logging is less verbose in the case of not logging each successful checksum -- and more verbose in the case of indicating each and every step through the transfer. These were decorated as I went with the python3 porting process.
|
Changes Unknown when pulling a14caad on functional-tests into * on master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements travis-ci integration with tox and lrzsz package.
Once I added tox support, I added python3 testing -- which immediately failed.
I spent some time adding python3 support. Some of the compatibility of using
bytearray() around str-data may incur some small overhead. We can address
these when we decide on a new API for YMODEM (multi-file, file-like iface)
support.
Additionally, debug logging is less verbose in the case of not logging each
successful checksum -- and more verbose in the case of indicating each and
every step through the transfer, and indicating the cause of various failures.
These were decorated as I went with the python3 porting process.