Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start Task from Last should use the Same generateName #666

Closed
danielhelfand opened this issue Jan 31, 2020 · 2 comments · Fixed by #670
Closed

Start Task from Last should use the Same generateName #666

danielhelfand opened this issue Jan 31, 2020 · 2 comments · Fixed by #670
Assignees
@16yuki0702
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@danielhelfand
Copy link
Member

danielhelfand commented Jan 31, 2020 •
edited
Loading

Similar to #639 but for TaskRuns. We should follow the same approach in #644 for tkn task start --last. Currently we are just using the task name for generateName:

cli/pkg/cmd/task/start.go

Line 189 in 2e5e541

tr.ObjectMeta.GenerateName = tname + "-run-"

@danielhelfand
Copy link
Member Author

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 31, 2020
16yuki0702 added a commit to 16yuki0702/cli that referenced this issue Feb 3, 2020
@16yuki0702
Fix overriding GenerateName on taskrun.
1822619 
This fixes tektoncd#666

when user specified last flag, script always override GenerateName.
So using GenerateName if last TaskRun has a GenerateName,
If not, setting a GenerateName based on last TaskRun Name.
@16yuki0702 16yuki0702 mentioned this issue Feb 3, 2020
Merged
5 tasks
@16yuki0702
Copy link
Member

/assign

tekton-robot pushed a commit that referenced this issue Feb 3, 2020
@16yuki0702 @tekton-robot
Fix overriding GenerateName on taskrun.
df58817 
This fixes #666

when user specified last flag, script always override GenerateName.
So using GenerateName if last TaskRun has a GenerateName,
If not, setting a GenerateName based on last TaskRun Name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@16yuki0702 16yuki0702

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix overriding GenerateName on taskrun 16yuki0702/cli
3 participants
@16yuki0702 @danielhelfand @tekton-robot