Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix overriding GenerateName on taskrun #670

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

16yuki0702
Copy link
Member

Changes

This fixes #666

when user specified last flag, script always override GenerateName.
So using GenerateName if last TaskRun has a GenerateName,
If not, setting a GenerateName based on last TaskRun Name.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

release-note

This fixes tektoncd#666

when user specified last flag, script always override GenerateName.
So using GenerateName if last TaskRun has a GenerateName,
If not, setting a GenerateName based on last TaskRun Name.
@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 3, 2020
@tekton-robot
Copy link
Contributor

Hi @16yuki0702. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 3, 2020
@chmouel
Copy link
Member

chmouel commented Feb 3, 2020

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 3, 2020
@chmouel
Copy link
Member

chmouel commented Feb 3, 2020

@16yuki0702 would you like to add your login to this list? : https://github.com/tektoncd/community/blob/master/org/org.yaml i think that's what needed so you don't need a ok-to-test for all your PR all the time

@16yuki0702
Copy link
Member Author

@chmouel

would you like to add your login to this list? : https://github.com/tektoncd/community/blob/master/org/org.yaml i think that's what needed so you don't need a ok-to-test for all your PR all the time

Yes, I'd like to add to the lists thanks 😄

@chmouel
Copy link
Member

chmouel commented Feb 3, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2020
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot merged commit df58817 into tektoncd:master Feb 3, 2020
@16yuki0702 16yuki0702 deleted the fix_bug_666 branch February 4, 2020 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start Task from Last should use the Same generateName
5 participants