Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all auth clients #628

Merged
merged 2 commits into from
Feb 4, 2020
Merged

Add all auth clients #628

merged 2 commits into from
Feb 4, 2020

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Jan 22, 2020 •
edited
Loading

Add all auth client-go clients as documented here https://git.io/JvL6r

Closes #627

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

release-note

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2020
@chmouel
Copy link
Member Author

chmouel commented Jan 22, 2020

Let me know if that works for you @tomhau01

thanks!

@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 22, 2020
@chmouel chmouel changed the title Add all auth client Add all auth clients Jan 22, 2020
@chmouel chmouel force-pushed the issue-627-missing-oidc-support-with-azure-active-directory branch from acace66 to a9d3024 Compare January 22, 2020 15:10
@ghost
Copy link

ghost commented Jan 22, 2020

Is there a binary somewhere I could test?

@chmouel
Copy link
Member Author

chmouel commented Jan 22, 2020

@tomhau01 there is not on CI but i can provide you one, is that for osx, linux?

@chmouel
Copy link
Member Author

chmouel commented Jan 22, 2020

Just saw that you are using OSX so here is a binary :

https://osinstall.chmouel.com/tmp/tkn

@chmouel chmouel force-pushed the issue-627-missing-oidc-support-with-azure-active-directory branch from a9d3024 to d175f22 Compare January 22, 2020 15:54
@ghost
Copy link

ghost commented Jan 22, 2020

Gave your binary a go, and it works. That was a very speedy fix, kudos!

@chmouel chmouel force-pushed the issue-627-missing-oidc-support-with-azure-active-directory branch from d175f22 to 9423d4a Compare January 22, 2020 16:09
@danielhelfand
Copy link
Member

Build error is:

-* Gophercloud no longer returns an error when multiple endpoints are found. Instead, it will choose the first endpoint and discard the others [GH-1766](https://github.com/gophercloud/gophercloud/pull/1766)

@ghost
Copy link

ghost commented Feb 3, 2020

No chance to get this into 0.7.0?

@chmouel chmouel force-pushed the issue-627-missing-oidc-support-with-azure-active-directory branch from 9423d4a to 08ae64f Compare February 3, 2020 16:21
@chmouel chmouel changed the title Add all auth clients Add azure auth clients Feb 3, 2020
@chmouel
Copy link
Member Author

chmouel commented Feb 3, 2020

@tomhau01 Sorry about this, I had some issues unfortunately with an unrelated (to azure) auth, let me try to rework this to only include the azure client.

I think it’s a bit late for 0.7.0 unfortunately as @piyush-garg is just finishing the release

@chmouel chmouel mentioned this pull request Feb 3, 2020
Closed
5 tasks
@ghost
Copy link

ghost commented Feb 4, 2020

Okay, thanks for looking into it.

@chmouel
Add all client-go dependency
d48476d 
Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@chmouel
Regenerate codegen and vendor for the client-go auth deps
f9f2fdc 
Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@chmouel chmouel force-pushed the issue-627-missing-oidc-support-with-azure-active-directory branch from 08ae64f to f9f2fdc Compare February 4, 2020 08:03
@chmouel chmouel changed the title Add azure auth clients Add all auth clients Feb 4, 2020
@chmouel
Copy link
Member Author

chmouel commented Feb 4, 2020

@tomhau01 Hey Tom, i have fixed the CI issues and we are going to be able to roll this in for 0.7.1 (0.7.0 had some issues), out of sanity check can you test this binary to make sure everything is fine? https://osinstall.chmouel.com/tmp/tkn thansk!

@ghost
Copy link

ghost commented Feb 4, 2020

Works fine!

@chmouel
Copy link
Member Author

chmouel commented Feb 4, 2020

@tomhau01 cool thanks you,

@piyush-garg that's ready for merg for 0.7.1

piyush-garg
piyush-garg approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@piyush-garg piyush-garg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks 🙇‍♂️

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2020
@tekton-robot tekton-robot merged commit c83ebb3 into tektoncd:master Feb 4, 2020
piyush-garg added a commit that referenced this pull request Feb 4, 2020
@piyush-garg
New version v0.7.1
458bd24 
#628 | [Chmouel Boudjnah] Add all client-go dependency | 2020/02/04-03:49
#628 | [Chmouel Boudjnah] Regenerate codegen and vendor for the client-go auth deps | 2020/02/04-03:49
#673 | [Piyush Garg] Update gotest.tools to use our fork | 2020/02/04-04:27

Signed-off-by: Piyush Garg <piyushgarg001@gmail.com>
@chmouel chmouel deleted the issue-627-missing-oidc-support-with-azure-active-directory branch June 27, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg piyush-garg approved these changes

@sthaha sthaha Awaiting requested review from sthaha

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing OIDC support with Azure Active Directory
5 participants
@chmouel @danielhelfand @tekton-robot @piyush-garg @googlebot