Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gotest.tool directly and not v3 #672

Closed
wants to merge 1 commit into from

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Feb 3, 2020

We have failure when using v3 failing with older version of go not having a go mod

pkg/cmd/pipelineresource/resource_testUtil.go:25:2: code in directory /Users/chmouel/GIT/go/src/github.com/tektoncd/cli/vendor/gotest.tools/v3/assert expects import "gotest.tools/assert"

do not use v3 directly in there

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

release-note

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 3, 2020
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 3, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielhelfand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2020
@piyush-garg
Copy link
Contributor

I0203 19:28:45.683] /go/src/github.com/tektoncd/cli is out of date. Please run hack/update-codegen.sh

We have failure when using v3 failing with older version of go not having a `go
mod`

```
pkg/cmd/pipelineresource/resource_testUtil.go:25:2: code in directory /Users/chmouel/GIT/go/src/github.com/tektoncd/cli/vendor/gotest.tools/v3/assert expects import "gotest.tools/assert"
```

do not use v3 directly in there

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@chmouel
Copy link
Member Author

chmouel commented Feb 3, 2020

@piyush-garg it seems that @vdemeester thinks we should really use gotest v3 for a reason, so i am going to hold onto this

@chmouel
Copy link
Member Author

chmouel commented Feb 3, 2020

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2020
@tekton-robot
Copy link
Contributor

@chmouel: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-tekton-cli-build-tests aee775f link /test pull-tekton-cli-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chmouel
Copy link
Member Author

chmouel commented Feb 3, 2020

I swear update-codegen is not working for me! same story as on #628

@chmouel
Copy link
Member Author

chmouel commented Feb 4, 2020

Vincent is working on it in:
gotestyourself/gotest.tools#184
/close

@tekton-robot
Copy link
Contributor

@chmouel: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chmouel chmouel deleted the use-gotest-tool branch June 27, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants