-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use gotest.tool directly and not v3 #672
Conversation
5a98cb8
to
20cea0f
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielhelfand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I0203 19:28:45.683] /go/src/github.com/tektoncd/cli is out of date. Please run hack/update-codegen.sh |
We have failure when using v3 failing with older version of go not having a `go mod` ``` pkg/cmd/pipelineresource/resource_testUtil.go:25:2: code in directory /Users/chmouel/GIT/go/src/github.com/tektoncd/cli/vendor/gotest.tools/v3/assert expects import "gotest.tools/assert" ``` do not use v3 directly in there Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
20cea0f
to
aee775f
Compare
@piyush-garg it seems that @vdemeester thinks we should really use gotest v3 for a reason, so i am going to hold onto this |
/hold |
@chmouel: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I swear update-codegen is not working for me! same story as on #628 |
Vincent is working on it in: |
@chmouel: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We have failure when using v3 failing with older version of go not having a
go mod
do not use v3 directly in there
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make docs
andmake man
if needed.make check
See the contribution guide
for more details.
Release Notes