-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Jonas to the org #106
Add Jonas to the org #106
Conversation
Jonas has recently become a regularly contributor. He started with adding a minor [_missing_ `omitempty`](tektoncd/pipeline#2301) and then [proposed some ideas](tektoncd/pipeline#1986 (comment)) around workspaces and PersistentVolumeClaim creation and continued to [elaborate around those ideas](tektoncd/pipeline#1986 (comment)). A sunny day a few days later, he also submitted an [extensive implementation for volumeClaimTemplate](tektoncd/pipeline#2326), corresponding to the idea discussions. A few days later submitted a [small refactoring PR](tektoncd/pipeline#2392), and he also listened to community members that [proposed changes](tektoncd/pipeline#2450) to his implementation about volumeClaimTemplates and did an [implementation for that proposal](tektoncd/pipeline#2453). A rainy day, he also wrote [technical documentation about PVCs](tektoncd/pipeline#2521) including adding an example that caused _flaky_ integration tests for the whole community during multiple days. When he understood his mistake, he submitted a [removal of the example](tektoncd/pipeline#2546) that caused flaky tests. He has also put his toe into Tekton Catalog and [contributed to the buildah task](tektoncd/pipeline#2546). This has followed, mostly with more PRs to the Pipeline project: - tektoncd/pipeline#2460 - tektoncd/pipeline#2491 - tektoncd/pipeline#2502 - tektoncd/pipeline#2506 - tektoncd/pipeline#2632 - tektoncd/pipeline#2633 - tektoncd/pipeline#2634 - tektoncd/pipeline#2636 - tektoncd/pipeline#2601 - tektoncd/pipeline#2630 Jonas is excited about the great community around Tekton and the project! He now would like to join the org.
/ok-to-test |
/lgtm |
/lgtm Thanks jonah and welcome to Tekton |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/meow
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @jlpettersson !!!! :D glad to have you! |
Signed-off-by: Trevor Rosen <trevrosen@github.com> Signed-off-by: Trevor Rosen <trevrosen@github.com>
Jonas has recently become a regular contributor. He started with adding a minor missing
omitempty
and then proposed some ideas around workspaces and PersistentVolumeClaim creation and continued to elaborate around those ideas. A sunny day a few days later, he also submitted an implementation for volumeClaimTemplate, corresponding to the discussed ideas.A few days later submitted a small refactoring PR, and he also listened to community members that proposed changes to his implementation about volumeClaimTemplates and did an implementation for that proposal.
A rainy day, he also wrote technical documentation about PVCs including adding an example that caused flaky integration tests for the whole community during multiple days. When he understood his mistake, he submitted a removal of the flaky example.
He has also put his toe into Tekton Catalog and contributed to the buildah task.
He has continued to contribute, mostly with more PRs to the Pipeline project:
Jonas is excited about the great community around Tekton and the project! He now would like to join the org.