Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidecar struct field Workspaces has not JSON annotation #3964

Closed
jeffmaury opened this issue May 20, 2021 · 0 comments · Fixed by #3966
Closed

Sidecar struct field Workspaces has not JSON annotation #3964

jeffmaury opened this issue May 20, 2021 · 0 comments · Fixed by #3966
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@jeffmaury
Copy link
Contributor

Expected Behavior

Field should be annotated with json:"workspaces,omitempty"

Actual Behavior

No annotation in source code.
@jeffmaury jeffmaury added the kind/bug Categorizes issue or PR as related to a bug. label May 20, 2021
jeffmaury added a commit to jeffmaury/pipeline that referenced this issue May 21, 2021
@jeffmaury
Fix Workspaces in Sidecar to be serialized as workspaces not Workspaces
7490a1f 
Fixes tektoncd#3964

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
@jeffmaury jeffmaury mentioned this issue May 21, 2021
Merged
5 tasks
tekton-robot pushed a commit that referenced this issue May 23, 2021
@jeffmaury @tekton-robot
Fix Workspaces in Sidecar to be serialized as workspaces not Workspaces
7f2eafa 
Fixes #3964

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
jerop pushed a commit to jerop/pipeline that referenced this issue Jun 7, 2021
@jeffmaury @jerop
Fix Workspaces in Sidecar to be serialized as workspaces not Workspaces
f7c81fd 
Fixes tektoncd#3964

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
jerop added a commit to jerop/pipeline that referenced this issue Jun 7, 2021
@jerop
Fix Workspaces in Sidecar to be serialized as workspaces not Workspaces
ffce317 
Workspaces field in Sidecar does not have a JSON annotation, therefore
it defaults to pascalcase. This is inconsistent with other fields that
are all lowercase. We need to dd the annotations to ensure that json
schema generators work correctly.

This change annotates the Workspaces field in Sidecar with
json:"workspaces,omitempty".

Fixes tektoncd#3964

(cherry picked from commits 7f2eafa,
0b80063,
a9b729b)

We need to cherry pick this change into v0.24 to avoid backwards
incompatibility and regressed behavior when we release v0.25
@jerop jerop mentioned this issue Jun 7, 2021
Closed
5 tasks
jerop added a commit to jerop/pipeline that referenced this issue Jun 8, 2021
@jerop
Fix Workspaces in Sidecar to be serialized as workspaces not Workspaces
0fcb6b8 
Workspaces field in Sidecar does not have a JSON annotation, therefore
it defaults to pascalcase. This is inconsistent with other fields that
are all lowercase. We need to dd the annotations to ensure that json
schema generators work correctly.

This change annotates the Workspaces field in Sidecar with
`json:"workspaces,omitempty"`.

Fixes tektoncd#3964

(cherry picked from commits 7f2eafa,
0b80063,
a9b729b)

We need to cherry pick this change into v0.24 to avoid backwards
incompatibility and regressed behavior when we release v0.25.
@jerop jerop mentioned this issue Jun 8, 2021
Merged
5 tasks
tekton-robot pushed a commit that referenced this issue Jun 8, 2021
@jerop @tekton-robot
Fix Workspaces in Sidecar to be serialized as workspaces not Workspaces
5c7a111 
Workspaces field in Sidecar does not have a JSON annotation, therefore
it defaults to pascalcase. This is inconsistent with other fields that
are all lowercase. We need to dd the annotations to ensure that json
schema generators work correctly.

This change annotates the Workspaces field in Sidecar with
`json:"workspaces,omitempty"`.

Fixes #3964

(cherry picked from commits 7f2eafa,
0b80063,
a9b729b)

We need to cherry pick this change into v0.24 to avoid backwards
incompatibility and regressed behavior when we release v0.25.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Workspaces in Sidecar to be serialized as workspaces not Workspaces jeffmaury/pipeline
1 participant
@jeffmaury