Fix Workspaces in Sidecar to be serialized as workspaces not Workspaces

[jeffmaury]

Fixes #3964

Signed-off-by: Jeff MAURY jmaury@redhat.com

Changes

Add JSON annotation in Workspaces field in Sidecar

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Docs included if any changes are user facing
• Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Jeff MAURY (7490a1f)

[tekton-robot]

Hi @jeffmaury. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[afrittoli]

/ok-to-test

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbwsg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/apis/OWNERS [sbwsg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ghost]

/test tekton-pipeline-unit-tests

[ghost]

/test pull-tekton-pipeline-build-tests

/test pull-tekton-pipeline-alpha-integration-tests

[ghost]

running ./hack/update-openapigen.sh and pushing the changes should fix the build tests.

/test pull-tekton-pipeline-alpha-integration-tests

[ghost]

Ah, apologies, a wrinkle in the way the hack scripts work: they need to be run from within a GOPATH otherwise they give relative references:

-	Ref:     ref("github.com/tektoncd/pipeline/pkg/apis/pipeline/v1beta1.WhenExpression"),
+	Ref:     ref("./pkg/apis/pipeline/v1beta1.WhenExpression"),

The way I do this is to symlink my dev directory to $GOPATH/src/github.com/tektoncd/pipeline:

ln -s <path to pipeline source code> $GOPATH/src/github.com/tektoncd/pipeline
cd $GOPATH/src/github.com/tektoncd/pipeline
./hack/update-openapigen.sh

🤞 hopefully that should net us the updated openapi spec w/ absolute references.

[tekton-robot]

@jeffmaury: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-tekton-pipeline-alpha-integration-tests	18bd514	link	/test pull-tekton-pipeline-alpha-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[chmouel]

/lgtm

[jerop]

we had the same issue with WhenExpressions fields – we had to support both cases for a while – we can avoid backwards incompatibility by patching 0.24