Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump knative to 0.22 🧙 #3883

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Bump knative to 0.22 🧙 #3883

merged 1 commit into from
Apr 21, 2021

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Apr 14, 2021 •
edited
Loading

Changes

Keeping knative up-to-date.
Fixes #3720

Signed-off-by: Vincent Demeester vdemeest@redhat.com

/kind misc

/cc @afrittoli @sbwsg

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

Update knative dependency to 0.22, and default minimum kubernetes version supported, v1.18.0

@tekton-robot tekton-robot requested review from afrittoli and a user April 14, 2021 21:39
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/misc Categorizes issue or PR as a miscellaneuous one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 14, 2021
@vdemeester vdemeester force-pushed the bump-knative-0-22 branch 2 times, most recently from 19f58b2 to de89568 Compare April 15, 2021 09:57
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 15, 2021
imjasonh
imjasonh reviewed Apr 15, 2021
View reviewed changes
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2021
@afrittoli
Copy link
Member

This will require upgrading our infra clusters :)

@vdemeester
Copy link
Member Author

This will require upgrading our infra clusters :)

@afrittoli are we still running 1.17 ?

@afrittoli
Copy link
Member

This will require upgrading our infra clusters :)

@afrittoli are we still running 1.17 ?

Yes, I updated them to 1.17 in December, so it's now time to a 1.18 update

@bobcatfish
Copy link
Collaborator

Fixes #3720 🎉 :D

@ghost
Copy link

ghost commented Apr 20, 2021

/lgtm

@tekton-robot tekton-robot assigned ghost Apr 20, 2021
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 20, 2021
@vdemeester
Copy link
Member Author

/retest

@bobcatfish bobcatfish added this to the Pipelines 0.24 milestone Apr 20, 2021
@ghost
Copy link

ghost commented Apr 20, 2021

You'll need to rebase on top of main to get the integration tests passing.

  1. git fetch upstream
  2. git rebase upstream/main
  3. git push --force <your remote> <branch name>

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 20, 2021
@vdemeester
Bump knative to 0.22 🧙
17f743a 
Keeping knative up-to-date.

Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
@tekton-robot tekton-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 21, 2021
pritidesai
pritidesai reviewed Apr 21, 2021
View reviewed changes
hack/update-deps.sh
@@ -22,7 +22,7 @@ source $(git rev-parse --show-toplevel)/vendor/github.com/tektoncd/plumbing/scri

cd ${REPO_ROOT_DIR}

VERSION="master"
VERSION="release-0.22"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@pritidesai
Copy link
Member

thank you @vdemeester

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2021
@tekton-robot tekton-robot merged commit 4de53b7 into tektoncd:main Apr 21, 2021
@vdemeester vdemeester deleted the bump-knative-0-22 branch April 21, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritidesai pritidesai pritidesai left review comments

@imjasonh imjasonh imjasonh left review comments

@afrittoli afrittoli Awaiting requested review from afrittoli

Assignees

@pritidesai pritidesai

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.24
Development

Successfully merging this pull request may close these issues.

Race condition on startup when using configuring controller via configmaps
6 participants
@vdemeester @tekton-robot @afrittoli @bobcatfish @pritidesai @imjasonh