-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip *heavy* validation on deletion 🙃 #3937
Skip *heavy* validation on deletion 🙃 #3937
Conversation
The following is the coverage report on the affected files.
|
Nice. This has also hit me when I'm developing a new feature. Going back to the current HEAD of pipelines/main means that the taskruns with the new feature syntax cannot be deleted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. I don't think I've seen IsInDelete
and related funcs from knative before.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Nice find! /lgtm |
/hold |
c736283
to
e67fce9
Compare
e67fce9
to
2b01218
Compare
The following is the coverage report on the affected files.
|
/hold cancel |
this is interesting, /lgtm |
Thanks for pointing it out. 🧑💻 👍 |
would this work? 🤔 /test pull-tekton-pipeline-alpha-integration-tests |
/retest |
When deleting an object, we don't need to pursue all the validation that we do at creation. It reduces the work to be done as part of the validation *and* allows invalid version of the resource (from previous versions for example) to be deleted safely. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
2b01218
to
3926b66
Compare
The following is the coverage report on the affected files.
|
/retest |
/lgtm |
/retest |
Changes
When deleting an object, we don't need to pursue all the validation
that we do at creation. It reduces the work to be done as part of the
validation and allows invalid version of the resource (from previous
versions for example) to be deleted safely.
Signed-off-by: Vincent Demeester vdemeest@redhat.com
The main reasoning for this change is to not face issues to reduce the situation where an upgrade makes object not deletable (because of newly invalid field). One example that happen in triggers is upgrading from 0.10.x to 0.12.x make
EventListener
not deletable at all./kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes