Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix issue with "$$" in Script blocks" #3938

Merged
merged 1 commit into from May 11, 2021
Merged

Revert "Fix issue with "$$" in Script blocks" #3938

merged 1 commit into from May 11, 2021

Conversation

ghost
Copy link

@ghost ghost commented May 11, 2021

Changes

Fixes #3935

This reverts commit 9a9f896.

Attempting to fix instances of "$$" introduced a new bug in the way
bash scripts are interpreted: #3935

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

Revert fix for instances of "$$" in script blocks. Kubernetes replaces "$$" with a single "$" and your scripts need to deal appropriately with these instances.

This reverts commit 9a9f896.

Attempting to fix instances of "$$" introduced a new bug in the way
bash scripts are interpreted: #3935
@ghost ghost requested a review from vdemeester May 11, 2021 11:42
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 11, 2021
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 11, 2021
@ghost
Copy link
Author

ghost commented May 11, 2021

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label May 11, 2021
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2021
@ghost ghost added the needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch label May 11, 2021
@jerop
Copy link
Member

jerop commented May 11, 2021

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 11, 2021
@tekton-robot tekton-robot merged commit 7ca5d61 into tektoncd:main May 11, 2021
@ghost ghost removed the needs-cherry-pick Indicates a PR needs to be cherry-pick to a release branch label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.24.0: broken bash variable evaluation
3 participants