Document behaviour of script field when "$$" and "$(X)" are used #3939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
kind/documentation
tekton-robot
added
the
release-note
tekton-robot
added
the
size/S
|
/hold This shouldn't be merged until after the |
tekton-robot
added
the
do-not-merge/hold
There are some nuances and slightly confusing behaviour present in the way our `script` field works. These relate to the way Kubernetes processes the `args` field of containers in order to replace variable references of form `$(X)`. This commit documents the way Kubernetes' variable reference code can mangle the contents of Tekton's `script` blocks.
|
/hold cancel #3938 has been merged. |
tekton-robot
removed
the
do-not-merge/hold
jerop
approved these changes
May 11, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jerop The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
ghost
mentioned this pull request
|
/hold We won't need this if #3963 goes in instead. |
tekton-robot
added
the
do-not-merge/hold
|
I'm closing this on the assumption that #3963 is probably the better way forward. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
There are some nuances and slightly confusing behaviour present in
the way our
scriptfield works. These relate to the way Kubernetesprocesses the
argsfield of containers in order to replace variablereferences of form
$(X).This commit documents the way Kubernetes' variable reference code
can mangle the contents of Tekton's
scriptblocks.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes