Remove reconciler check for enable-tekton-oci-bundles flag #6777
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the "bundle" field is only allowed in a v1beta1 TaskRef or PipelineRef if "enable-tekton-oci-bundles" is set to "true". This is validated in the admission webhook.
v1 TaskRefs and PipelineRefs may not contain the "bundle" field.
Prior to this commit, implementation for TaskRefs and PipelineRefs also checked this field. If this field was not set to "true", the PipelineRun and TaskRun reconcilers would attempt to fetch the Pipeline/Task from the cluster instead of from an image registry, which is not correct behavior, and there were no tests for having this flag set to "false" with bundle syntax.
In addition, when we convert from v1beta1 to v1, "bundle" syntax is transformed into bundle resolver syntax. This means when we swap the storage version of the API to v1, the reconciler will stop checking whether the "enable-tekton-oci-bundles" flag is set anyway.
This commit removes this check, fixing the incorrect behavior. The reconciler will correctly reconcile TaskRuns and PipelineRuns with bundle references if they have been accepted by the validation webhook.
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes