Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reconciler check for enable-tekton-oci-bundles flag #6777

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

lbernick
Copy link
Member

@lbernick lbernick commented Jun 5, 2023

Currently, the "bundle" field is only allowed in a v1beta1 TaskRef or PipelineRef if "enable-tekton-oci-bundles" is set to "true". This is validated in the admission webhook.
v1 TaskRefs and PipelineRefs may not contain the "bundle" field.

Prior to this commit, implementation for TaskRefs and PipelineRefs also checked this field. If this field was not set to "true", the PipelineRun and TaskRun reconcilers would attempt to fetch the Pipeline/Task from the cluster instead of from an image registry, which is not correct behavior, and there were no tests for having this flag set to "false" with bundle syntax.

In addition, when we convert from v1beta1 to v1, "bundle" syntax is transformed into bundle resolver syntax. This means when we swap the storage version of the API to v1, the reconciler will stop checking whether the "enable-tekton-oci-bundles" flag is set anyway.

This commit removes this check, fixing the incorrect behavior. The reconciler will correctly reconcile TaskRuns and PipelineRuns with bundle references if they have been accepted by the validation webhook.

/kind bug

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • n/a Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • n/a Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • n/a Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

Currently, the "bundle" field is only allowed in a v1beta1 TaskRef
or PipelineRef if "enable-tekton-oci-bundles" is set to "true".
This is validated in the admission webhook.
v1 TaskRefs and PipelineRefs may not contain the "bundle" field.

Prior to this commit, implementation for TaskRefs and PipelineRefs
also checked this field. If this field was not set to "true", the
PipelineRun and TaskRun reconcilers would attempt to fetch the Pipeline/Task
from the cluster instead of from an image registry, which is not correct behavior,
and there were no tests for having this flag set to "false" with bundle syntax.

In addition, when we convert from v1beta1 to v1, "bundle" syntax is transformed
into bundle resolver syntax. This means when we swap the storage version of the API
to v1, the reconciler will stop checking whether the "enable-tekton-oci-bundles" flag
is set anyway.

This commit removes this check, fixing the incorrect behavior.
The reconciler will correctly reconcile TaskRuns and PipelineRuns with bundle references
if they have been accepted by the validation webhook.
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/bug Categorizes issue or PR as related to a bug. labels Jun 5, 2023
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 5, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.8% 93.6% -0.1
pkg/reconciler/taskrun/resources/taskref.go 90.0% 89.9% -0.1

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2023
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/pipelinerun/resources/pipelineref.go 93.8% 93.6% -0.1
pkg/reconciler/taskrun/resources/taskref.go 90.0% 89.9% -0.1

@JeromeJu
Copy link
Member

JeromeJu commented Jun 5, 2023

/lgtm
Thanks Lee!

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2023
@tekton-robot tekton-robot merged commit c163b1c into tektoncd:main Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants