Commits on Jun 5, 2023

1. Remove reconciler check for enable-tekton-oci-bundles flag …

   Currently, the "bundle" field is only allowed in a v1beta1 TaskRef
   or PipelineRef if "enable-tekton-oci-bundles" is set to "true".
   This is validated in the admission webhook.
   v1 TaskRefs and PipelineRefs may not contain the "bundle" field.
   
   Prior to this commit, implementation for TaskRefs and PipelineRefs
   also checked this field. If this field was not set to "true", the
   PipelineRun and TaskRun reconcilers would attempt to fetch the Pipeline/Task
   from the cluster instead of from an image registry, which is not correct behavior,
   and there were no tests for having this flag set to "false" with bundle syntax.
   
   In addition, when we convert from v1beta1 to v1, "bundle" syntax is transformed
   into bundle resolver syntax. This means when we swap the storage version of the API
   to v1, the reconciler will stop checking whether the "enable-tekton-oci-bundles" flag
   is set anyway.
   
   This commit removes this check, fixing the incorrect behavior.
   The reconciler will correctly reconcile TaskRuns and PipelineRuns with bundle references
   if they have been accepted by the validation webhook.

   

   lbernick committed Jun 5, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 308be68
   • Browse repository at this point

   Copy the full SHA

   308be68 View commit details

   Browse the repository at this point in the history