Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not generate sync activity task for deleted activity #2572

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Do not generate sync activity task for deleted activity #2572

merged 1 commit into from
Mar 4, 2022

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Mar 4, 2022

What changed?

  • Do not generate sync activity task for deleted activity

Why?

  • The generated sync activity will be a no-op as the activity has already closed

How did you test it?

  • Existing tests

Potential risks

Is hotfix candidate?
no

@yycptt yycptt requested a review from a team as a code owner March 4, 2022 20:10
@yycptt yycptt mentioned this pull request Mar 4, 2022
Merged
@yycptt yycptt merged commit db40f02 into temporalio:master Mar 4, 2022
@yycptt yycptt deleted the no-sync-deleted-activity branch March 4, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxing1292 wxing1292 wxing1292 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yycptt @wxing1292