Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker env to control OIDC auth scopes #254

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Add docker env to control OIDC auth scopes #254

merged 1 commit into from
Nov 16, 2022

Conversation

feedmeapples
Copy link
Contributor

@feedmeapples feedmeapples commented Nov 14, 2022

What was changed

Added TEMPORAL_AUTH_SCOPES that allows to customize auth scopes when running in docker

Why?

resolve #210

Checklist

  1. Closes

  2. How was this tested:

built & started docker with OIDC auth setup -> went through login flow. Verified that changing TEMPORAL_AUTH_SCOPES results in changes in docker.yml

docker run \
    --network host \
    -e TEMPORAL_ADDRESS=127.0.0.1:7233 \
    -e TEMPORAL_UI_PORT=8080 \
    -e TEMPORAL_AUTH_ENABLED=true \
    -e TEMPORAL_AUTH_PROVIDER_URL=https://accounts.google.com \
    -e TEMPORAL_AUTH_CLIENT_ID=xxx \
    -e TEMPORAL_AUTH_CLIENT_SECRET=yyy \
    -e TEMPORAL_AUTH_CALLBACK_URL=http://localhost:8080/auth/sso/callback \
    -e TEMPORAL_AUTH_SCOPES=openid,email,profile \
    ui
  1. Any docs updates needed?

A notion in release docs about the breaking change + docs update

{{ end }}
{{ end }}
forwardHeaders: {{ if .Env.TEMPORAL_FORWARD_HEADERS }} {{ range $seed := (split .Env.TEMPORAL_FORWARD_HEADERS ",") }}
- {{ . }} {{ end }} {{ end }}
Copy link
Contributor Author

@feedmeapples feedmeapples Nov 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for reviewers: it was producing many empty lines

@feedmeapples feedmeapples changed the title Add docker env to control OIDC auth scopes Allow customizing auth scopes with Docker env variable Nov 15, 2022
@feedmeapples feedmeapples changed the title Allow customizing auth scopes with Docker env variable Add docker env to control OIDC auth scopes Nov 15, 2022
@feedmeapples feedmeapples merged commit 041ee99 into main Nov 16, 2022
@feedmeapples feedmeapples deleted the scopes-env branch November 16, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Allow configuring auth scopes with Docker env variable
2 participants