Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker env to control OIDC auth scopes #254

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Add docker env to control OIDC auth scopes #254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docker/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ docker run \
-e TEMPORAL_AUTH_CLIENT_ID=xxxxx-xxxx.apps.googleusercontent.com \
-e TEMPORAL_AUTH_CLIENT_SECRET=xxxxxxxxxxxxxxx \
-e TEMPORAL_AUTH_CALLBACK_URL=https://xxxx.com:8080/auth/sso/callback \
-e TEMPORAL_AUTH_SCOPES=openid,email,profile \
-e TEMPORAL_TLS_CA=../ca.cert \
-e TEMPORAL_TLS_CERT=../cluster.pem \
-e TEMPORAL_TLS_KEY=../cluster.key \
Expand Down
14 changes: 4 additions & 10 deletions docker/config_template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,16 +33,10 @@ auth:
clientId: {{ .Env.TEMPORAL_AUTH_CLIENT_ID }}
clientSecret: {{ .Env.TEMPORAL_AUTH_CLIENT_SECRET }}
callbackUrl: {{ .Env.TEMPORAL_AUTH_CALLBACK_URL }}
scopes:
- openid
- profile
- email
scopes: {{ if .Env.TEMPORAL_AUTH_SCOPES }} {{ range $seed := (split .Env.TEMPORAL_AUTH_SCOPES ",") }}
- {{ . }} {{ end }} {{ end }}
codec:
endpoint: {{ default .Env.TEMPORAL_CODEC_ENDPOINT "" }}
passAccessToken: {{ default .Env.TEMPORAL_CODEC_PASS_ACCESS_TOKEN "false" }}
forwardHeaders: # comma separated list of headers to pass from HTTP API requests to Temporal gRPC backend
{{ if .Env.TEMPORAL_FORWARD_HEADERS }}
{{ range $seed := (split .Env.TEMPORAL_FORWARD_HEADERS ",") }}
- {{ . }}
{{ end }}
{{ end }}
forwardHeaders: {{ if .Env.TEMPORAL_FORWARD_HEADERS }} {{ range $seed := (split .Env.TEMPORAL_FORWARD_HEADERS ",") }}
- {{ . }} {{ end }} {{ end }}
Copy link
Contributor Author

@feedmeapples feedmeapples Nov 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for reviewers: it was producing many empty lines