Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add address endpoint and release swagger v1.0.0 #90

Merged
merged 4 commits into from
Nov 11, 2021

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Nov 11, 2021

Description

closes: #89


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@dongsam dongsam changed the title feat: add address endpoint feat: add address endpoint and release swagger v1.0.0 Nov 11, 2021
@dongsam dongsam merged commit eca1ac9 into tendermint:main Nov 11, 2021
@dongsam
Copy link
Contributor Author

dongsam commented Nov 11, 2021

@hallazzang @kogisin I know it's hard to review due to the retreat, but Let me merge it first due to the release schedule. Please review it later.

Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the Greece retreat, I just reviewed and left some comments. If necessary, we can work on the other PR to apply the suggestions.

x/budget/client/cli/flags.go Show resolved Hide resolved
x/budget/client/cli/query.go Show resolved Hide resolved
x/budget/client/cli/query.go Show resolved Hide resolved
x/budget/client/cli/query.go Show resolved Hide resolved
x/budget/keeper/grpc_query.go Show resolved Hide resolved
x/budget/keeper/grpc_query.go Show resolved Hide resolved
x/budget/types/utils.go Show resolved Hide resolved
x/budget/types/utils.go Show resolved Hide resolved
@dongsam
Copy link
Contributor Author

dongsam commented Nov 23, 2021

@kogisin Thanks for the suggestions, I just commit on #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add address endpoint to derive
2 participants