Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable more linters #258

Closed
liamsi opened this issue Mar 6, 2019 · 1 comment
Closed

Enable more linters #258

liamsi opened this issue Mar 6, 2019 · 1 comment
Labels
improvement

Comments

@liamsi
Copy link
Contributor

liamsi commented Mar 6, 2019 •
edited
Loading

With #255 (not merged yet) we've switched to golangci-lint. Most linters are disabled though as the code wouldn't pass those lints.

We should enable a few more (ideally all) linters one by one (in separate PRs). We should start with go vet.
@tac0turtle tac0turtle mentioned this issue Aug 2, 2019
Merged
@tac0turtle tac0turtle mentioned this issue Aug 6, 2019
Merged
tac0turtle added a commit that referenced this issue Aug 6, 2019
@tac0turtle
Lint Galore
f31394c 
- added a few linters

ref #258

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@tac0turtle tac0turtle mentioned this issue Aug 6, 2019
Merged
tac0turtle added a commit that referenced this issue Aug 16, 2019
@tac0turtle
Lint Galore (#281)
9dc1454 
* Lint Galore

- added a few linters

ref #258

Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>

* Apply suggestions from code review

Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com>

* ci fix
@tac0turtle
Copy link
Contributor

closing this with the most recent PR: #296

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liamsi @tac0turtle