add linters to go-amino #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
commented
Aug 2, 2019
| @@ -441,7 +441,7 @@ func encodeFieldNumberAndTyp3(w io.Writer, num uint32, typ Typ3) (err error) { | |||
| if (typ & 0xF8) != 0 { | |||
| panic(fmt.Sprintf("invalid Typ3 byte %v", typ)) | |||
| } | |||
| if num < 0 || num > (1<<29-1) { | |||
There was a problem hiding this comment.
uint32 can not be less than 0
tac0turtle
commented
Aug 2, 2019
| @@ -270,7 +271,7 @@ func decodeNanos(bz *[]byte, n *int) (int32, error) { | |||
| return 0, err | |||
| } | |||
| // Validation check. | |||
| if nsec < 0 || maxNanos < nsec { | |||
There was a problem hiding this comment.
uint can not be less than 0
melekes
reviewed
Aug 2, 2019
melekes
approved these changes
Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #258