Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(monitoringc): increase code coverage #730

Merged
merged 7 commits into from
Apr 21, 2022
Merged

Conversation

giunatale
Copy link
Contributor

Part of #687

What does this PR does?

Increase code coverage for x/monitoringc

note: code coverage is not increased for types/params.go since the module does not have params and the file only contains boilerplate code

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #730 (75414ff) into develop (d775e6a) will increase coverage by 0.12%.
The diff coverage is 8.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #730      +/-   ##
===========================================
+ Coverage    11.21%   11.34%   +0.12%     
===========================================
  Files          278      278              
  Lines        60780    60780              
===========================================
+ Hits          6817     6894      +77     
+ Misses       53783    53718      -65     
+ Partials       180      168      -12     
Impacted Files Coverage Δ
pkg/types/ibc.pb.go 0.69% <4.34%> (ø)
pkg/types/consensus_state.go 100.00% <100.00%> (ø)
x/monitoringc/keeper/handshake.go 100.00% <0.00%> (+3.57%) ⬆️
x/monitoringc/keeper/msg_create_client.go 95.38% <0.00%> (+23.07%) ⬆️
x/monitoringc/types/genesis.go 100.00% <0.00%> (+25.71%) ⬆️
x/monitoringc/keeper/monitoring_packet.go 100.00% <0.00%> (+100.00%) ⬆️
x/monitoringc/keeper/grpc_verified_client_ids.go 100.00% <0.00%> (+100.00%) ⬆️

aljo242
aljo242 previously approved these changes Apr 20, 2022
Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

For the onrecv test with rewards distributions, I think we should rely on mocks at some point but it would concern a bigger refactoring for the testkeeper package that include mocked keeper dependencies

proto/types/ibc.proto Outdated Show resolved Hide resolved
@giunatale
Copy link
Contributor Author

👍

For the onrecv test with rewards distributions, I think we should rely on mocks at some point but it would concern a bigger refactoring for the testkeeper package that include mocked keeper dependencies

I agree 100%.

@aljo242 aljo242 merged commit 8a4a18e into develop Apr 21, 2022
@aljo242 aljo242 deleted the chore/codecov-monitoringc branch April 21, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants