-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(monitoringc
): increase code coverage
#730
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #730 +/- ##
===========================================
+ Coverage 11.21% 11.34% +0.12%
===========================================
Files 278 278
Lines 60780 60780
===========================================
+ Hits 6817 6894 +77
+ Misses 53783 53718 -65
+ Partials 180 168 -12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
For the onrecv test with rewards distributions, I think we should rely on mocks at some point but it would concern a bigger refactoring for the testkeeper
package that include mocked keeper dependencies
I agree 100%. |
Part of #687
What does this PR does?
Increase code coverage for
x/monitoringc
note: code coverage is not increased for
types/params.go
since the module does not have params and the file only contains boilerplate code