test(monitoringc): increase code coverage

pkg/types/consensus_state.go

@@ -49,7 +49,7 @@ func NewConsensusState(timestamp, nextValHash, rootHash string) ConsensusState {
 	return ConsensusState{
 		NextValidatorsHash: nextValHash,
 		Timestamp:          timestamp,
-		Root: MerkelRool{
+		Root: MerkleRoot{
 			Hash: rootHash,
 		},
 	}

pkg/types/consensus_state_test.go

@@ -14,7 +14,7 @@ import (
 func TestConsensusState_RootHash(t *testing.T) {
 	csf := types.ConsensusState{
 		NextValidatorsHash: "foo",
-		Root: types.MerkelRool{
+		Root: types.MerkleRoot{
 			Hash: "bar",
 		},
 		Timestamp: "foobar",

proto/types/ibc.proto

@@ -5,8 +5,8 @@ import "gogoproto/gogo.proto";
 
 option go_package = "github.com/tendermint/spn/pkg/types";
 
-// MerkelRool represents a Merkel Root in ConsensusState
-message MerkelRool {
+// MerkleRoot represents a Merkle Root in ConsensusState
+message MerkleRoot {
   string hash = 1;
 }
 
@@ -15,7 +15,7 @@ message MerkelRool {
 message ConsensusState {
   string nextValidatorsHash = 1;
   string timestamp = 2;
-  MerkelRool root = 3 [(gogoproto.nullable) = false];
+  MerkleRoot root = 3 [(gogoproto.nullable) = false];
 }
 
 

x/monitoringc/keeper/grpc_verified_client_ids_test.go

@@ -0,0 +1,65 @@
+package keeper_test
+
+import (
+	"testing"
+
+	sdk "github.com/cosmos/cosmos-sdk/types"
+	"github.com/stretchr/testify/require"
+	"google.golang.org/grpc/codes"
+	"google.golang.org/grpc/status"
+
+	testkeeper "github.com/tendermint/spn/testutil/keeper"
+	"github.com/tendermint/spn/testutil/nullify"
+	"github.com/tendermint/spn/x/monitoringc/types"
+)
+
+func TestVerifiedClientIds(t *testing.T) {
+	ctx, tk, _ := testkeeper.NewTestSetup(t)
+	wctx := sdk.WrapSDKContext(ctx)
+	items := createNVerifiedClientID(ctx, tk.MonitoringConsumerKeeper, 2)
+	for _, tc := range []struct {
+		desc     string
+		request  *types.QueryGetVerifiedClientIdsRequest
+		response *types.QueryGetVerifiedClientIdsResponse
+		err      error
+	}{
+		{
+			desc: "first",
+			request: &types.QueryGetVerifiedClientIdsRequest{
+				LaunchID: items[0].LaunchID,
+			},
+			response: &types.QueryGetVerifiedClientIdsResponse{ClientIds: items[0].ClientIDs},
+		},
+		{
+			desc: "second",
+			request: &types.QueryGetVerifiedClientIdsRequest{
+				LaunchID: items[1].LaunchID,
+			},
+			response: &types.QueryGetVerifiedClientIdsResponse{ClientIds: items[1].ClientIDs},
+		},
+		{
+			desc: "key not found",
+			request: &types.QueryGetVerifiedClientIdsRequest{
+				LaunchID: 100000,
+			},
+			err: status.Error(codes.Internal, "launch id not found 100000"),
+		},
+		{
+			desc: "invalid request",
+			err:  status.Error(codes.InvalidArgument, "invalid request"),
+		},
+	} {
+		t.Run(tc.desc, func(t *testing.T) {
+			response, err := tk.MonitoringConsumerKeeper.VerifiedClientIds(wctx, tc.request)
+			if tc.err != nil {
+				require.ErrorIs(t, err, tc.err)
+			} else {
+				require.NoError(t, err)
+				require.Equal(t,
+					nullify.Fill(tc.response),
+					nullify.Fill(response),
+				)
+			}
+		})
+	}
+}

x/monitoringc/keeper/handshake_test.go

@@ -202,4 +202,19 @@ func TestKeeper_RegisterProviderClientIDFromChannelID(t *testing.T) {
 		err := tk.MonitoringConsumerKeeper.RegisterProviderClientIDFromChannelID(ctx, "foo")
 		require.ErrorIs(t, err, types.ErrConnectionAlreadyEstablished)
 	})
+
+	t.Run("should fail if monitoring connection already enabled on chain", func(t *testing.T) {
+		ctx, tk, _ := testSetupWithFooClient(t)
+		tk.MonitoringConsumerKeeper.SetLaunchIDFromVerifiedClientID(ctx, types.LaunchIDFromVerifiedClientID{
+			LaunchID: 1,
+			ClientID: "foo",
+		})
+		chain := launchtypes.Chain{
+			LaunchID:            1,
+			MonitoringConnected: true,
+		}
+		tk.LaunchKeeper.SetChain(ctx, chain)
+		err := tk.MonitoringConsumerKeeper.RegisterProviderClientIDFromChannelID(ctx, "foo")
+		require.ErrorIs(t, err, launchtypes.ErrChainMonitoringConnected)
+	})
 }