Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: usage of rand in simulation test #740

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Conversation

lumtis
Copy link
Contributor

@lumtis lumtis commented Apr 21, 2022

Change rand usage with r variable to prevent non-determinism issue in simulation tests

@lumtis lumtis linked an issue Apr 21, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #740 (87a9215) into develop (9dfd9b0) will increase coverage by 0.00%.
The diff coverage is 62.50%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #740   +/-   ##
========================================
  Coverage    11.21%   11.21%           
========================================
  Files          278      278           
  Lines        60780    60780           
========================================
+ Hits          6817     6819    +2     
+ Misses       53783    53782    -1     
+ Partials       180      179    -1     
Impacted Files Coverage Δ
x/campaign/simulation/simulation.go 0.00% <0.00%> (ø)
x/campaign/simulation/store.go 82.43% <100.00%> (+1.35%) ⬆️

x/campaign/simulation/store.go Outdated Show resolved Hide resolved
@lumtis lumtis requested a review from giunatale April 21, 2022 14:00
@giunatale giunatale merged commit d775e6a into develop Apr 21, 2022
@giunatale giunatale deleted the fix/simulation-random branch April 21, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-determinism in simulation
3 participants