Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly set lastBlockHeight in localnet #745

Merged
merged 3 commits into from
Apr 25, 2022

Conversation

giunatale
Copy link
Contributor

Closes #744

aljo242
aljo242 previously approved these changes Apr 22, 2022
@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #745 (95dca66) into develop (424657d) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #745   +/-   ##
========================================
  Coverage    11.40%   11.40%           
========================================
  Files          280      280           
  Lines        61479    61479           
========================================
+ Hits          7012     7014    +2     
+ Misses       54302    54301    -1     
+ Partials       165      164    -1     
Impacted Files Coverage Δ
x/campaign/simulation/store.go 82.43% <0.00%> (+1.35%) ⬆️

Copy link
Contributor

@lumtis lumtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually tried this solution but we still get the error

goroutine 1 [running]:
github.com/cosmos/cosmos-sdk/x/params/types.Subspace.Get({{0x665ec60, 0xc001224340}, 0xc000010748, {0x663a598, 0xc000f747f0}, {0x663a5e8, 0xc000f74900}, {0xc000188de0, 0xb, 0x22}, ...}, ...)
	/Users/lucas/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.45.3/x/params/types/subspace.go:109 +0x307
github.com/tendermint/spn/x/monitoringp/keeper.Keeper.LastBlockHeight(...)

@giunatale
Copy link
Contributor Author

I don't seem to

@aljo242
Copy link
Contributor

aljo242 commented Apr 22, 2022

I don't seem to

Same here. Works for me

@giunatale
Copy link
Contributor Author

@lubtd make sure you've cleaned up your nodes perhaps? might contain old corrupted data

@lumtis
Copy link
Contributor

lumtis commented Apr 25, 2022

Found the issue👍

spnd unsafe-reset-all has been moved to spnd tendermint unsafe-reset-all since SDK v0.45.3
Therefore the clear script was not correctly cleaning up the environment

I made a commit for it , just 3 lines change

@giunatale giunatale requested a review from aljo242 April 25, 2022 15:56
@lumtis lumtis merged commit 0b443ae into develop Apr 25, 2022
@lumtis lumtis deleted the fix/localnet-lastblockheight branch April 25, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

localnet network start script fails
3 participants