add async methods to the sync client class #22
Conversation
modelz/aioclient.py
Outdated
| console.print(await self.data) | ||
|
|
||
|
|
||
| class ModelzClient: |
There was a problem hiding this comment.
Why there are two ModelzClient? Can they be the same one or inherit from some base class?
There was a problem hiding this comment.
Thanks for reviewing my code. I could rename modelz/aioclient.py's ModelzClient to something else, like AioModelzClient, would that work?
Yes they could inherit from the same ABC, but since the classes are simple, I don't see much benefit doing that now.
|
|
||
| async def _post(self, url, content, timeout): | ||
| headers = self.auth.get_headers() | ||
| async with aiohttp.ClientSession() as session: |
There was a problem hiding this comment.
I tried that, see https://github.com/tddschn/nssurge-api/blob/f2aafe1b01877b8ff8bfc6e74a58736a7ba3b058/nssurge_api/api.py#L30
Definding self.session in init() would require also defining __aenter__ and __aexit__ methods, and request methods that uses self.session to use an async context manager (see https://github.com/tddschn/nssurge-cli/blob/112e600fad6299d4f78012b7aaa20dfb0cdb9758/nssurge_cli/cap_commands.py#L20), due to how aiohttp works.
I'll try to figure out a better way to support session reuse.
| async def save_to_file(self, file: str): | ||
| with open(file, "wb") as f: | ||
| f.write(await self.data) | ||
|
|
||
| @property | ||
| async def data(self) -> Any: | ||
| if not self._data: | ||
| self._data = self.serde.decode(await self.resp.content.read()) | ||
| return self._data | ||
|
|
||
| async def show(self): | ||
| console.print(await self.data) |
There was a problem hiding this comment.
Does the sync interface work with this?
See https://github.com/tddschn/aiomodelz for details.