Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add async methods to the sync client class #22
base: main
Are you sure you want to change the base?
add async methods to the sync client class #22
Changes from 3 commits
afdf7c7
41b3dc6
0036a99
230479a
ef8f5a6
dbc2cc9
cb0b3e1
ded20ed
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the sync interface work with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reuse the session.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried that, see https://github.com/tddschn/nssurge-api/blob/f2aafe1b01877b8ff8bfc6e74a58736a7ba3b058/nssurge_api/api.py#L30
Definding self.session in init() would require also defining
__aenter__
and__aexit__
methods, and request methods that uses self.session to use an async context manager (see https://github.com/tddschn/nssurge-cli/blob/112e600fad6299d4f78012b7aaa20dfb0cdb9758/nssurge_cli/cap_commands.py#L20), due to how aiohttp works.I'll try to figure out a better way to support session reuse.