Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typing sparsemax function and cleanup typing info #1031

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Add typing sparsemax function and cleanup typing info #1031

merged 2 commits into from
Feb 6, 2020

Conversation

autoih
Copy link
Member

@autoih autoih commented Feb 6, 2020 •
edited
Loading

typing of sparsemax function (#989)

@autoih autoih requested a review from a team as a code owner February 6, 2020 20:24
gabrieldemarmiesse
gabrieldemarmiesse approved these changes Feb 6, 2020
View reviewed changes
Copy link
Member

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks! Waiting for tests to finish.

@gabrieldemarmiesse gabrieldemarmiesse merged commit a0fcf54 into tensorflow:master Feb 6, 2020
@autoih autoih deleted the text1 branch February 9, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldemarmiesse gabrieldemarmiesse gabrieldemarmiesse approved these changes

Assignees
No one assigned
Labels
build cla: yes losses
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@autoih @gabrieldemarmiesse @googlebot