Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add typegurad and types #971

Merged
merged 5 commits into from
Jan 30, 2020
Merged

add typegurad and types #971

merged 5 commits into from
Jan 30, 2020

Conversation

autoih
Copy link
Member

@autoih autoih commented Jan 29, 2020

Hopefully this PR helps, linked to #894.

@boring-cyborg boring-cyborg bot added the layers label Jan 29, 2020
@seanpmorgan
Copy link
Member

Thanks @autoih!

Would you mind removing these from the exception list:
https://github.com/tensorflow/addons/blob/master/tools/ci_build/verify/check_typing_info.py#L27

@autoih autoih requested a review from a team as a code owner January 30, 2020 00:47
@boring-cyborg boring-cyborg bot added the build label Jan 30, 2020
@autoih
Copy link
Member Author

autoih commented Jan 30, 2020

Thanks @seanpmorgan. I also removed some (maxout, gelu, etc) have been updated.

gabrieldemarmiesse
gabrieldemarmiesse reviewed Jan 30, 2020
View reviewed changes
Copy link
Member

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!

tensorflow_addons/layers/poincare.py Outdated Show resolved Hide resolved
@gabrieldemarmiesse
Copy link
Member

Nice :)

@gabrieldemarmiesse gabrieldemarmiesse merged commit eab9282 into tensorflow:master Jan 30, 2020
failure-to-thrive pushed a commit to failure-to-thrive/addons that referenced this pull request Feb 1, 2020
@autoih
add typegurad and types (tensorflow#971)
4a8bf89 
* adding typegurad and types

* black run

* remove exception list

* add missing annotation

* minor correction
@gabrieldemarmiesse gabrieldemarmiesse mentioned this pull request Feb 4, 2020
Closed
@autoih autoih deleted the type1 branch February 9, 2020 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldemarmiesse gabrieldemarmiesse gabrieldemarmiesse approved these changes

@facaiy facaiy Awaiting requested review from facaiy

@seanpmorgan seanpmorgan Awaiting requested review from seanpmorgan

Assignees
No one assigned
Labels
build cla: yes layers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@autoih @seanpmorgan @gabrieldemarmiesse @googlebot