-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev to staging #62
Merged
dev to staging #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: fixed and added some changes * fix: fixed from PR feedback
perf/rate-limiter
perf: add cache in db layer
* refactor: update metric api to cumulate task count after db purge - increment the task result count everytime the api is called instead of fetch from TaskResult table - use Redis INCR for atomic increments that work across all instances * fix: fixed from PR feedback - added some changes for PR feedback - removed cache on GetTasksByWorkerSubscription to fix task list not properly updated * fix: add more changes for PR, and edges cases - add TasksByWorker cache back that was removed because of inconsistent UI - reset the related cache after successful task sumit, or create - refactor some code in cache.go - add some changes from PR feedback * chore: clean up substrate logs * fix: bug fixed on changing expired time - use UTC on current time when checking on expired task - remove the check for expire task with no result, since schedular handling it already
karootplx
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.