Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yolov4 head sub_module fails in main #11998

Closed
punithsekar opened this issue Aug 28, 2024 · 7 comments
Closed

Yolov4 head sub_module fails in main #11998

punithsekar opened this issue Aug 28, 2024 · 7 comments
Assignees
Labels
bug Something isn't working CNNs P2

Comments

@punithsekar
Copy link
Contributor

punithsekar commented Aug 28, 2024

Describe the bug
yolov4 head sub_module fails in main after this commit in main.

RuntimeError: TT_FATAL @ ../ttnn/cpp/ttnn/operations/matmul/device/matmul_op.cpp:977: bias_shape.without_padding()[-1] == b_shape[-1]
E       info:
E       Unsupported bias shape: last dimension not equal to second input's last dimension.
E       backtrace:
E        --- ttnn::operations::matmul::Matmul::validate(std::__1::vector<tt::tt_metal::Tensor, std::__1::allocator<tt::tt_metal::Tensor>> const&, std::__1::vector<std::__1::optional<tt::tt_metal::Tensor const>, std::__1::allocator<std::__1::optional<tt::tt_metal::Tensor const>>> const&) const 

To Reproduce
Steps to reproduce the behavior:

  1. Checkout keerthanar/yolov4_bias_issue_unit_test
  2. Run pytest tt-metal/tests/ttnn/unit_tests/operations/test_new_conv2d.py::test_yolov4_bias_issue_case

Please complete the following environment information:

  • OS: Ubuntu 20.04
  • Device- n150
@punithsekar punithsekar added the bug Something isn't working label Aug 28, 2024
@punithsekar
Copy link
Contributor Author

Temporarily, I have skipped those test in main.

PR #11959

@tt-rkim
Copy link
Collaborator

tt-rkim commented Aug 28, 2024

Note @eyonland for planning

@mywoodstock
Copy link
Contributor

cc: @bbradelTT

@bbradelTT
Copy link
Contributor

Starting to work on this.

  1. I think test_yolov4_bias_issue_case is duplicated in the file on the branch
  2. I think the repro step should be
pytest tests/ttnn/unit_tests/operations/test_new_conv2d.py::test_yolov4_bias_issue_case
  1. I can check for both padded and non-padded. That allows the test to pass. I need to see if there are any negative consequences. If not, I'll get a PR out.

@keerthana-r-mcw
Copy link
Contributor

keerthana-r-mcw commented Sep 6, 2024

Hi @bbradelTT , The issue got resolved with this matmul_op.cpp fix given by Sankar.
NOTE: We tested the fix locally, but it has not yet been merged into the main.

@punithsekar
Copy link
Contributor Author

The issue has been solved.
#12503 PR for removing the skip statements.

@punithsekar
Copy link
Contributor Author

Merged #12503 to main.
Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CNNs P2
Projects
None yet
Development

No branches or pull requests

5 participants