Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YoloV4 pipeline update #12503

Merged
merged 4 commits into from
Sep 17, 2024
Merged

YoloV4 pipeline update #12503

merged 4 commits into from
Sep 17, 2024

Conversation

keerthana-r-mcw
Copy link
Contributor

@keerthana-r-mcw keerthana-r-mcw commented Sep 11, 2024 •
edited by punithsekar
Loading

Problem description

Updated the pipeline with shard concat and replaced the fallback maxpool with ttnn.maxpool2d, remove skip statements for head,whole model pipeline. Add input files to the repo.

What's changed

  • Changed the interleaved concat to shared concat in downsample2 and downsample3 as mentiontined in #12182. Other submodules were failing with this change as in #12387
  • Replaced the fallback maxpool with tthh.Maxpool2d
  • Remove skip statements for head, whole model.
  • Add input files to run demo.

@punithsekar punithsekar force-pushed the punith/yolov4_update branch 2 times, most recently from e757209 to a0d0734 Compare September 11, 2024 09:44
@punithsekar punithsekar mentioned this pull request Sep 16, 2024
Closed
@punithsekar
Copy link
Contributor

All post commit tests CI pipeline run is in progress https://github.com/tenstorrent/tt-metal/actions/runs/10876570979

@punithsekar
Copy link
Contributor

Passing CI link

dvartaniansTT
dvartaniansTT approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@dvartaniansTT dvartaniansTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks

@punithsekar
Copy link
Contributor

Passing CI Link.

@punithsekar punithsekar merged commit b016ceb into main Sep 17, 2024
6 checks passed
@punithsekar punithsekar deleted the punith/yolov4_update branch September 17, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvartaniansTT dvartaniansTT dvartaniansTT approved these changes

@eyonland eyonland eyonland approved these changes

@saichandax saichandax Awaiting requested review from saichandax

@patrickroberts patrickroberts Awaiting requested review from patrickroberts

@yan-zaretskiy yan-zaretskiy Awaiting requested review from yan-zaretskiy

@cfjchu cfjchu Awaiting requested review from cfjchu cfjchu is a code owner

@xanderchin xanderchin Awaiting requested review from xanderchin

@TT-BrianLiu TT-BrianLiu Awaiting requested review from TT-BrianLiu TT-BrianLiu is a code owner

@ayerofieiev-tt ayerofieiev-tt Awaiting requested review from ayerofieiev-tt ayerofieiev-tt is a code owner

@dmakoviichuk-tt dmakoviichuk-tt Awaiting requested review from dmakoviichuk-tt dmakoviichuk-tt is a code owner

@razorback3 razorback3 Awaiting requested review from razorback3 razorback3 is a code owner

@dongjin-na dongjin-na Awaiting requested review from dongjin-na dongjin-na is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keerthana-r-mcw @punithsekar @eyonland @dvartaniansTT